Bug 1583745

Summary: python-mccabe FTBFS on python 3.7
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-mccabeAssignee: Orphan Owner <extras-orphan>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: extras-orphan, ncoghlan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-31 12:31:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1565020    
Attachments:
Description Flags
build.log from copr
none
root.log from copr none

Description Miro Hrončok 2018-05-29 15:16:38 UTC 
Created attachment 1445451 [details]
build.log from copr

Description of problem: python-mccabe FTBFS on python 3.7 due to failed test:

+ py.test-2.7
============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILD/mccabe-0.6.1, inifile:
collected 14 items
test_mccabe.py ss............                                            [100%]
===================== 12 passed, 2 skipped in 0.04 seconds =====================
+ py.test-3
============================= test session starts ==============================
platform linux -- Python 3.7.0b4, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILD/mccabe-0.6.1, inifile:
collected 14 items
test_mccabe.py ..F...........                                            [100%]
=================================== FAILURES ===================================
____________________ McCabeTestCase.test_expr_as_statement _____________________
self = <test_mccabe.McCabeTestCase testMethod=test_expr_as_statement>
    def test_expr_as_statement(self):
        complexity = get_complexity_number(expr_as_statement, self.strio)
>       self.assertEqual(complexity, 1)
E       AssertionError: 2 != 1
test_mccabe.py:192: AssertionError
===================== 1 failed, 13 passed in 0.09 seconds ======================


Version-Release number of selected component (if applicable):	0.6.1-7.fc29

Logs attached.
Comment 1 Miro Hrončok 2018-05-29 15:17:52 UTC 
Created attachment 1445452 [details]
root.log from copr
Comment 2 Miro Hrončok 2018-05-29 15:25:50 UTC 
Orphan. I asked for it in https://pagure.io/releng/issue/7533
Comment 3 Alyssa Coghlan 2018-05-30 12:11:54 UTC 
Note that this test failure is likely to away in 3.7.0b5, since we reverted the AST change that caused it: https://github.com/python/cpython/pull/7121

(Upstream may still want to change their test though, since we're still planning to make a change along these lines for 3.8)
Comment 4 Miro Hrončok 2018-05-31 12:31:18 UTC 
Indeed. Builds fine with b5.