Bug 1583859

Summary:	Review Request: nodejs-estree-walker - Traverse an ESTree-compliant AST
Product:	[Fedora] Fedora	Reporter:	Jared Smith <jsmith.fedora>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-30 15:01:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1495387
Bug Blocks:	956806, 1387531, 1572709

Description Jared Smith 2018-05-29 22:42:06 UTC

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-estree-walker/nodejs-estree-walker.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-estree-walker/nodejs-estree-walker-0.5.2-1.fc29.src.rpm
Description: Traverse an ESTree-compliant AST
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-05-30 13:39:25 UTC

 - You already have a bug opened for this package: https://bugzilla.redhat.com/show_bug.cgi?id=1495393  I suggest closing the other one as a Duplicate.


 - Therollup command is not found:

Exécution_de(%build) : /bin/sh -e /var/tmp/rpm-tmp.Pn6rWk
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ rm dist/estree-walker.es.js dist/estree-walker.es.js.map dist/estree-walker.umd.js dist/estree-walker.umd.js.map
+ rollup -i src/estree-walker.js -f umd -n estreeWalker -m -o dist/estree-walker.umd.js
BUILDSTDERR: /var/tmp/rpm-tmp.Pn6rWk: line 34: rollup: command not found

   You need to add nodejs-rollup as a BR:

%if !%{?bootstrap}
BuildRequires:	nodejs-rollup
%endif



 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.


Would you mind reviewing https://bugzilla.redhat.com/show_bug.cgi?id=1583887 in exchange if you have the time?

Comment 2 Jared Smith 2018-05-30 13:47:39 UTC

Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6818.

Comment 3 Gwyn Ciesla 2018-05-30 14:02:49 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-estree-walker

Comment 4 Jared Smith 2018-05-30 15:01:19 UTC

Packaged in Rawhide, closing this issue

Comment 5 Jared Smith 2018-05-30 15:02:16 UTC

*** Bug 1495393 has been marked as a duplicate of this bug. ***