Bug 1584152

Summary:	[day2] Updated hosts are not persisted both the gdeploy config files
Product:	[oVirt] cockpit-ovirt	Reporter:	Mugdha Soni <musoni>
Component:	Gdeploy	Assignee:	Parth Dhanjal <dparth>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mugdha Soni <musoni>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	0.11.20	CC:	bugs, rhs-bugs, sabose, sankarshan, sasundar
Target Milestone:	ovirt-4.2.5	Flags:	sasundar: ovirt-4.2? sasundar: planning_ack? rule-engine: devel_ack+ sasundar: testing_ack+
Target Release:	0.11.29
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.11.29-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1584151	Environment:
Last Closed:	2018-07-31 15:27:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1584151, 1596277

Description Mugdha Soni 2018-05-30 12:02:18 UTC

+++ This bug was initially created as a clone of Bug #1584151 +++

Description of problem:
-----------------------------------------------------------
The change in any parameters required for expand cluster after the failed deployment is not reflected in the gdeploy conf file which is regenerated on redeploy because the change regarding the error is made in file "/var/lib/ovirt-hosted-engine-setup/gdeploy/gdeployConfig.conf " and not in "  /var/lib/ovirt-hosted-engine-setup/gdeploy/expandClusterConfig.conf '.

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.11.999-0.0.master.el7.noarch


How reproducible:
--------------------------------------------------------------
Eerytime

Steps to Reproduce:
--------------------------------------------------------------
1.Successfully deploy gluster and hosted engine.
2.Reach out to the gluster management wizard via hosted engine .
3.Click on ' expand cluster ' button , configure the paramneters and then deploy.

Actual results:
---------------------------------------------------------------
The change in parameter in any of the tabs is not reflected in the  regenerated conf file after redeployment.

Expected results:
--------------------------------------------------------------------
The change in any of the parameter should be reflected in the regenerated gdeploy conf file.


Additional info:-
------------------------------------------------------------------------
The changes should be made on both of these file rather than a single file.
 "/var/lib/ovirt-hosted-engine-setup/gdeploy/gdeployConfig.conf "
 "  /var/lib/ovirt-hosted-engine-setup/gdeploy/expandClusterConfig.conf '.

Comment 1 SATHEESARAN 2018-06-01 14:46:50 UTC

This issue is seen with expand cluster operation on the cockpit day2 operations. While trying to update the host names after passing the first tab ( take a case where the customer prefers to update the hostnames, or redeploying after failed attempt ), the new host names are persisted in the gdeploy config file used for configuring those hosts, but the other gdeploy file used for peer probing was not really updated and still refers to the old host lists

Comment 2 SATHEESARAN 2018-07-19 09:48:00 UTC

Tested with cockpit-ovirt-dashboard-0.11.30-1 with the following steps:

1. Proceed to 'Virtualization' tab -> 'HostedEngine' -> 'Gluster Management' -> 'Expand cluster'

2. New wizard pops-up, and provide the hostnames as 'host12', 'host13', 'host14'
Note that this hostnames are not resolvable and doesn't exists. These hostnames are picked for the deployment to fail

3. Proceed with custom values for fields on other tab and proceed to deployment.

4. Once the deployment fails, click on 'Redeploy' and go back to the first tab and update the hostnames to 'host121', 'host131', 'host141'

5. Go to the last tab where you can see the generated gdeploy config file, but do not click on deployment.

6. Validate the gdeploy config files
# grep -A4 hosts /var/lib/ovirt-hosted-engine-setup/gdeploy/expandClusterConfig.conf 

# grep -A3 hosts /var/lib/ovirt-hosted-engine-setup/gdeploy/gdeployConfig.conf 

The list contains the updated hosts

Comment 3 Sandro Bonazzola 2018-07-31 15:27:34 UTC

This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.