Bug 1584731

Summary:	Review Request: nodejs-is-function - Is that thing a function? Use this module to find out
Product:	[Fedora] Fedora	Reporter:	Jared Smith <jsmith.fedora>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-31 16:13:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	956806, 1572709, 1584735

Description Jared Smith 2018-05-31 14:00:36 UTC

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-function/nodejs-is-function.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-function/nodejs-is-function-1.0.1-1.fc29.src.rpm
Description: Is that thing a function? Use this module to find out
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-05-31 15:02:16 UTC

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.imIdoh
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ /usr/bin/tape test.js
BUILDSTDERR: /var/tmp/rpm-tmp.imIdoh: line 35: /usr/bin/tape: No such file or directory

   Add tape to the BR:

%if 0%{?enable_tests}
BuildRequires:	mocha
BuildRequires:	npm(tape)
%endif


 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 2 Jared Smith 2018-05-31 15:16:44 UTC

Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6844.

Comment 3 Gwyn Ciesla 2018-05-31 15:22:51 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-is-function

Comment 4 Jared Smith 2018-05-31 16:13:40 UTC

Packaged in Rawhide, closing this issue