Bug 1585221

Summary:	CVE-2018-11627 rubygem-sinatra: XSS in the 400 Bad Request page [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Andrej Nemec <anemec>
Component:	rubygem-sinatra	Assignee:	Jun Aruga <jaruga>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	28	CC:	jaruga, lkundrak, valtri, vondruch
Target Milestone:	---	Keywords:	Reopened, Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-sinatra-2.0.3-1.fc29, rubygem-sinatra-2.0.0-4.fc28, rubygem-sinatra-2.0.0-3.fc27 rubygem-sinatra-2.0.0-4.fc28	Doc Type:	Release Note
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-23 19:55:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1585218

Description Andrej Nemec 2018-06-01 14:37:06 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Comment 1 Andrej Nemec 2018-06-01 14:37:11 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1585218,1585221

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Jun Aruga 2018-06-12 19:24:58 UTC

The patch is available on sinatra >= 2.0.2.
Fedora rawhide rubygem-sinatra is now 2.0.3.
This should be fixed.

> Upstream patch:
>
> https://github.com/sinatra/sinatra/commit/12786867d6faaceaec62c7c2cb5b0e2dc074d71a

Comment 3 Vít Ondruch 2018-06-13 08:25:29 UTC

@Jun, could you please also take a look on F27, F28? It seems the patch should be easy to backport. Thx

Comment 4 Jun Aruga 2018-06-13 10:33:45 UTC

@Vit, okay, I can do it.

Comment 5 Fedora Update System 2018-06-14 15:30:02 UTC

rubygem-sinatra-2.0.0-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0b17e1e529

Comment 6 Fedora Update System 2018-06-14 15:30:12 UTC

rubygem-sinatra-2.0.0-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3f61c5cf7c

Comment 7 Fedora Update System 2018-06-14 18:23:42 UTC

rubygem-sinatra-2.0.0-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0b17e1e529

Comment 8 Fedora Update System 2018-06-14 20:25:02 UTC

rubygem-sinatra-2.0.0-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3f61c5cf7c

Comment 9 Jun Aruga 2018-06-14 20:50:32 UTC

Hi QA team.

You can test the security issue with the testing script.
See my forked rubygem-sinatra repository's blow branch latest commit "[DEBUG] Add test for CVE-2018-11627." to use the script.

f27-fix-xss-for-http-400-request-page-test branch
https://src.fedoraproject.org/fork/jaruga/rpms/rubygem-sinatra/commits/feature/f27-fix-xss-for-http-400-request-page-test

f28-fix-xss-for-http-400-request-page-test branch
https://src.fedoraproject.org/fork/jaruga/rpms/rubygem-sinatra/commits/feature/f28-fix-xss-for-http-400-request-page-test

Comment 10 Fedora Update System 2018-06-23 19:55:28 UTC

rubygem-sinatra-2.0.0-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-06-23 20:46:36 UTC

rubygem-sinatra-2.0.0-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.