Bug 1585227

Summary: [Infra] New transaction leak in netvirt.fibmanager.VrfEntryListener
Product: Red Hat OpenStack Reporter: Sai Sindhur Malleni <smalleni>
Component: opendaylightAssignee: Michael Vorburger <vorburger>
Status: CLOSED ERRATA QA Contact: Sai Sindhur Malleni <smalleni>
Severity: medium Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: aadam, joflynn, mkolesni, nyechiel, vorburger
Target Milestone: z2Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: Infra
Fixed In Version: opendaylight-8.3.0-2.el7ost Doc Type: Bug Fix
Doc Text:
Previously, the transaction did not close in netvirt.fibmanager.VrfEntryListener. This resulted in memory leaks at scale and/or in longevity. This issue has been resolved and OpenDaylight now requires less memory to run.
Story Points: ---
Clone Of: Environment:
N/A
Last Closed: 2018-08-29 16:20:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1577975    

Description Sai Sindhur Malleni 2018-06-01 15:01:24 UTC
Description of problem:
Running performance and scale tests that create 100s of neutron resources like networks, subnets, ports and routers as well as launching VMs on the networks and waiting for the environment to quiesce, we observe some new transaction leaks based on Michael Vorburger's mdsal-trace tool.

  24x transactions opened here, which are not closed:
      (...)
      org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
      (...)
      org.opendaylight.netvirt.fibmanager.VrfEntryListener.lambda$populateFibOnNewDpn$17(VrfEntryListener.java:1575)
      org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416)
      org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60)
      java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402)
      java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
      java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
      java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)

Version-Release number of selected component (if applicable):
OSP13
ODL Oxygen

How reproducible:
100%

Steps to Reproduce:
1. Deploy OSP with ODL
2. Run perf and scale tests
3.

Actual results:
Found open transactions after environment was quiesced 

Expected results:
No large number of open transactions

Additional info:

Comment 1 Michael Vorburger 2018-06-01 15:43:48 UTC
NETVIRT-1291: This is already fixed on ODL upstream master; Stephen will cherry-pick - thank you!

Comment 11 Joanne O'Flynn 2018-08-14 09:45:45 UTC
This bug is marked for inclusion in the errata but does not currently contain draft documentation text. To ensure the timely release of this advisory please provide draft documentation text for this bug as soon as possible.

If you do not think this bug requires errata documentation, set the requires_doc_text flag to "-".


To add draft documentation text:

* Select the documentation type from the "Doc Type" drop down field.

* A template will be provided in the "Doc Text" field based on the "Doc Type" value selected. Enter draft text in the "Doc Text" field.

Comment 12 Sai Sindhur Malleni 2018-08-16 12:13:13 UTC
Verified in opendaylight-8.3.0-3.el7ost.noarch

Comment 14 errata-xmlrpc 2018-08-29 16:20:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2598