Bug 1585406
| Summary: | /etc/schroot/default/* files overwritten on upgrade (not marked as %config) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | David O'Shea <dcoshea> |
| Component: | schroot | Assignee: | Sergio Basto <sergio> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel7 | CC: | agk, os, sergio |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | schroot-1.6.10-4.fc28 schroot-1.6.10-4.fc27 schroot-1.6.10-4.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-06-29 08:42:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
schroot-1.6.10-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b44a43897a schroot-1.6.10-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ced9a8ff3 schroot-1.6.10-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-e98be8da12 schroot-1.6.10-4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ced9a8ff3 schroot-1.6.10-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b44a43897a schroot-1.6.10-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-e98be8da12 schroot-1.6.10-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. schroot-1.6.10-4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. schroot-1.6.10-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: When I upgraded from 1.6.5-5.el7, my changes to /etc/schroot/default/{copyfiles,fstab} were lost. I assume this is because those files aren't marked as configuration files by the package. Version-Release number of selected component (if applicable): 1.6.10-3.el7 How reproducible: Don't know, but I would assume 100%. Steps to Reproduce: 1. Install schroot-1.6.5-5.el7 on CentOS 7. 2. Modify /etc/schroot/default/{copyfiles,fstab} . 3. 'yum update'. Actual results: Either /etc/schroot/default/{copyfiles,fstab}.rpmnew file(s) get created, or no new files are created at all. I think the latter should have occurred in this case, as I don't think there were actually any changes in those files between the packages - when I compared the result of 'yum update' in these files against my backup, I only saw my additions that had been lost. Expected results: My changes are missing from /etc/schroot/default/{copyfiles,fstab} . Additional info: I gather that these are all of the files marked as configuration files by the package, so these are the only ones that are safe from being lost on upgrade: """ $ rpm -q --configfiles schroot /etc/pam.d/schroot /etc/schroot/buildd/copyfiles /etc/schroot/buildd/fstab /etc/schroot/buildd/nssdatabases /etc/schroot/sbuild/copyfiles /etc/schroot/sbuild/fstab /etc/schroot/sbuild/nssdatabases /etc/schroot/schroot.conf """ I don't know what the packaging guidelines rules are for this, but the buildd/ and sbuild/ directories contain the same sets of files as the default/, desktop/, and minimal/ directories, so I assume that the latter 3 should be set as %config(noreplace) in the .spec file too. It seems like the difference is that buildd/ and sbuild/ are new - they weren't in the previous version of the package (or at least weren't on my system prior to the upgrade, based on my backup), so I guess %config(noreplace) was set for those but was never there for the existing directories. Note that the schroot.conf man page says "Desktop users should note that the fstab file desktop/fstab will need editing if you use gdm3", so these are clearly files that are intended to be edited. Perhaps all of /etc/schroot/ should be set as %config(noreplace)? If I had modified any of the scripts under /etc/schroot/setup.d/, I wouldn't want them to be lost during the upgrade either (in fact, I think I did this on another machine I've yet to apply this update to).