Bug 1585494
| Summary: | NetworkManager-1.11.4-1.fc29 causes compose failure on aarch64 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> | ||||||||
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> | ||||||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 29 | CC: | alexl, bgalvani, dcbw, fgiudici, john.j5live, lkundrak, mclasen, rhughes, rstrode, sandmann, thaller | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2019-11-27 19:23:34 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Kevin Fenzi
2018-06-03 16:27:17 UTC
Created attachment 1447357 [details]
[PATCH] manager: fix failed assertion on user activations
Created attachment 1447360 [details]
[PATCH v2] manager: fix failed assertion on user activations
(In reply to Beniamino Galvani from comment #2) > Created attachment 1447360 [details] > [PATCH v2] manager: fix failed assertion on user activations Patch looks good, anyway why not just remove the 'gs_unref_object' in the var declaration? We never need to free 'active' in impl_manager_activate_connection(). So we will have to remove the "g_steal_pointer" as in the patch but will not need to add it after the call to nm_active_connection_authorize(). (In reply to Francesco Giudici from comment #3) > (In reply to Beniamino Galvani from comment #2) > > Created attachment 1447360 [details] > > [PATCH v2] manager: fix failed assertion on user activations > > Patch looks good, anyway why not just remove the 'gs_unref_object' I think gs_unref_object is favorable. "We never need to free 'active' in impl_manager_activate_connection()." is IMO not true. At the "error:" label, we do need to unref @active (and do so). gs_unref_object clearly ~documents~ that the @active variable owns a reference. At it also clearly documents the single place, where the ownership is passed on ("stolen"). patch lgtm. (In reply to Francesco Giudici from comment #3) > (In reply to Beniamino Galvani from comment #2) > > Created attachment 1447360 [details] > > [PATCH v2] manager: fix failed assertion on user activations > > Patch looks good, anyway why not just remove the 'gs_unref_object' in the > var declaration? We never need to free 'active' in > impl_manager_activate_connection(). > So we will have to remove the "g_steal_pointer" as in the patch but will not > need to add it after the call to nm_active_connection_authorize(). Yes, this is a possible alternative, I just wanted to keep the patch closer to what previous code did (+ what Thomas said). Applied to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=7696e6c1fa871236832a1e4eb6671c406efba867 (In reply to Thomas Haller from comment #4) > (In reply to Francesco Giudici from comment #3) > > (In reply to Beniamino Galvani from comment #2) > > > Created attachment 1447360 [details] > > > [PATCH v2] manager: fix failed assertion on user activations > > > > Patch looks good, anyway why not just remove the 'gs_unref_object' > > I think gs_unref_object is favorable. > > "We never need to free 'active' in impl_manager_activate_connection()." is > IMO not true. At the "error:" label, we do need to unref @active (and do so). What I mean, is that when we arrive at the "error:" label, @active is NULL. So there is nothing to unref. Either @active is already NULL after _new_active_connection () and we jump to "error:" or we have a reference on @active and we make it NULL (leaving it to nm_active_connection_authorize() ) to prevent the gs_unref to be applied when falling back to "error:". So, looked a bit weird putting gs_unref and then taking care that it never happens... but patch is ok. > > gs_unref_object clearly ~documents~ that the @active variable owns a > reference. At it also clearly documents the single place, where the > ownership is passed on ("stolen"). Yeah, I can understand your point of view. > > > patch lgtm. This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle. Changing version to '29'. This message is a reminder that Fedora 29 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '29'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 29 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |