Bug 1585565

Spec URL: https://sites.google.com/site/mohammedisam2000/home/projects/shaman.spec
SRPM URL: https://sites.google.com/site/mohammedisam2000/home/projects/shaman-1.0-1.fc28.src.rpm

Apologies for the previous broken links.

>Group: Applications/Accessories
Drop this.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>%post
>/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
>
>%postun
>if [ $1 -eq 0 ] ; then
>    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
>    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
>fi
The icon cache scriptlets are no longer needed. Remove them and add "Requires: hicolor-icon-theme" instead.

>%files
>%{_datadir}/icons/hicolor/256x256/apps/%{name}.png
>%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
>%{_datadir}/icons/hicolor/24x24/apps/%{name}.png
In %files, you can use "aaa/*/bbb" to match multiple directories.

>%files
>%%doc AUTHORS NEWS THANKS README COPYING ChangeLog
Mark COPYING as %license.

(In reply to Artur Iwicki from comment #2)
> >Group: Applications/Accessories
> Drop this.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

I dropped this, and the %clean section, as in the guidelines.

> >%post
> >/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> >/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> >
> >%postun
> >if [ $1 -eq 0 ] ; then
> >    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> >    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> >fi
> The icon cache scriptlets are no longer needed. Remove them and add
> "Requires: hicolor-icon-theme" instead.

Fixed.

> >%files
> >%{_datadir}/icons/hicolor/256x256/apps/%{name}.png
> >%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
> >%{_datadir}/icons/hicolor/24x24/apps/%{name}.png
> In %files, you can use "aaa/*/bbb" to match multiple directories.

Fixed.

> 
> >%files
> >%%doc AUTHORS NEWS THANKS README COPYING ChangeLog
> Mark COPYING as %license.

Fixed.

Spec URL: https://sites.google.com/site/mohammedisam2000/home/projects/shaman.spec
SRPM URL: https://sites.google.com/site/mohammedisam2000/home/projects/shaman-1.0-2.fc28.src.rpm

 - Please use your Fedora People space instead of Google to host your files, see https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org?rd=Fedorapeople.org#Accessing_Your_fedorapeople.org_Space

 - Not needed:

%defattr(-,root,root,-)

 - Install the doc but without COPYING:

%doc AUTHORS NEWS THANKS README ChangeLog
%license COPYING

 - %{_datadir}/metainfo → %{_metainfodir}  (F28+ only)

 - Remove:

update-desktop-database &> /dev/null ||:

 - This shouldn't be necessary as you already installing the man page with 644 perm:

chmod -x %{buildroot}%{_mandir}/man1/shaman.1

 - Not needed:

Requires(post): info
Requires(post): desktop-file-utils
Requires(preun): info
Requires(post): desktop-file-utils

(In reply to Robert-André Mauchin from comment #5)
>  - Please use your Fedora People space instead of Google to host your files,

Done. New links are added below.

>  - Not needed:
> %defattr(-,root,root,-)

Removed.

>  - Install the doc but without COPYING:
> %doc AUTHORS NEWS THANKS README ChangeLog
> %license COPYING

Fixed.

>  - %{_datadir}/metainfo → %{_metainfodir}  (F28+ only)

Fixed.

>  - Remove:
> update-desktop-database &> /dev/null ||:

Removed.

>  - This shouldn't be necessary as you already installing the man page with
> 644 perm:
> chmod -x %{buildroot}%{_mandir}/man1/shaman.1

Removed.

>  - Not needed:
> Requires(post): info
> Requires(post): desktop-file-utils
> Requires(preun): info
> Requires(post): desktop-file-utils

Removed.

Spec URL: https://mohammedisam.fedorapeople.org/shaman.spec
SRPM URL: https://mohammedisam.fedorapeople.org/shaman-1.0-3.fc28.src.rpm

 - Build error:

Preparing build tree
mkdir -p build
Creating info file from texi source
makeinfo info/shaman.texi
BUILDSTDERR: make: makeinfo: Command not found
BUILDSTDERR: make: *** [Makefile:94: shaman.info] Error 127

   It seems you need to add texinfo as a BR


 - Another build error:


cp src/mima/shaman/*.java build
cd build; javac -g -d out -sourcepath . Utility.java ShamanMainWindow.java Cache.java FindDialog.java HelpScreen.java ManDBParser.java ManpageDocument.java ManpageDocumentLoader.java ManualSection.java ProgressDialog.java SettingsDialog.java  Shaman.java TreeElement.java Updater.java FileFilterAllFormats.java FileFilterHTML.java FileFilterManpages.java FileFilterTXT.java; \
[ $? -eq 0 ] || exit 2
BUILDSTDERR: /bin/sh: javac: command not found
BUILDSTDERR: make: *** [Makefile:71: build/shaman.jar] Error 2
BUILDSTDERR: make: *** Waiting for unfinished jobs....


   Please make sure you've got all the BR needed to build that package and do a build with mock. ( https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds?rd=PackageMaintainers/MockTricks#How_do_I_use_Mock.3F )

(In reply to Robert-André Mauchin from comment #8)

>  - Build error:
> Preparing build tree
> mkdir -p build
> Creating info file from texi source
> makeinfo info/shaman.texi
> BUILDSTDERR: make: makeinfo: Command not found
> BUILDSTDERR: make: *** [Makefile:94: shaman.info] Error 127
> 
>    It seems you need to add texinfo as a BR

Fixed.

>  - Another build error:
> cp src/mima/shaman/*.java build
> cd build; javac -g -d out -sourcepath . Utility.java ShamanMainWindow.java
> Cache.java FindDialog.java HelpScreen.java ManDBParser.java
> ManpageDocument.java ManpageDocumentLoader.java ManualSection.java
> ProgressDialog.java SettingsDialog.java  Shaman.java TreeElement.java
> Updater.java FileFilterAllFormats.java FileFilterHTML.java
> FileFilterManpages.java FileFilterTXT.java; \
> [ $? -eq 0 ] || exit 2
> BUILDSTDERR: /bin/sh: javac: command not found
> BUILDSTDERR: make: *** [Makefile:71: build/shaman.jar] Error 2
> BUILDSTDERR: make: *** Waiting for unfinished jobs....
> 
>    Please make sure you've got all the BR needed to build that package and
> do a build with mock. (

I did. Mock build succeeded (I didn't get any errors down to the line that says Finish: run). The log files are also error-free.

Spec URL: https://mohammedisam.fedorapeople.org/shaman.spec
SRPM URL: https://mohammedisam.fedorapeople.org/shaman-1.0-4.fc28.src.rpm

 - Still doesn't work:

+ cp -p shaman-256.png /builddir/build/BUILDROOT/shaman-1.0-4.fc29.x86_64/usr/share/icons/hicolor/256x256/apps/shaman.png
BUILDSTDERR: cp: cannot stat 'shaman-256.png': No such file or directory

I can't find these icons anywhere. There's no shaman.appdata.xml or shaman.desktop either. Are you sure you uploaded the right archive to your website? It seems it's not the same one as in the SRPM, that's why it fails since I'm downloading the original during build. Please update it.

Also you need to add javapackages-tools as a BR to use 
%jpackage_script

(In reply to Robert-André Mauchin from comment #11)

> I can't find these icons anywhere. There's no shaman.appdata.xml or
> shaman.desktop either. Are you sure you uploaded the right archive to your
> website? It seems it's not the same one as in the SRPM, that's why it fails
> since I'm downloading the original during build. Please update it.

Awww, my bad. You are absolutely right, I forgot to upload the correct tar archive. I fixed this now.

> Also you need to add javapackages-tools as a BR to use 
> %jpackage_script

Fixed.

Would you please check it again?

Spec URL: https://mohammedisam.fedorapeople.org/shaman.spec
SRPM URL: https://mohammedisam.fedorapeople.org/shaman-1.0-5.fc28.src.rpm

 - [!]: Packages are noarch unless they use JNI
     Note: shaman subpackage is not noarch. Please verify manually

   Your package should be noarch.

BuildArch: noarch


 - Your .desktop file is linking to /bin/shaman: it should be /usr/bin/shaman:

[Desktop Entry]
Version=1.0
Type=Application
Name=Shaman
GenericName=Shaman
Comment=Man pages viewer
Exec=/usr/bin/shaman %F
Icon=shaman
Terminal=false
Categories=Applications;Utility;
Name[en_US]=shaman

 - The THANKS file is empty, don't install it with %doc

 - Remove the comment %global debug_package %{nil} and/or escape the macros which are in comment by doubling the %:

* Tue Jun 26 2018 Mohammed Isam <mohammed_isam1984> 1.0-5
- Fixed the spec file (added %%jpackage_script BuildRequires clause)


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "GPL (v3 or later)", "Unknown or generated", "GFDL (v1.7
     or later)". 32 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/shaman/review-
     shaman/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Texinfo files are installed using install-info in %post and %preun if
     package has .info files.
     Note: Texinfo .info file(s) in shaman
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[!]: Packages are noarch unless they use JNI
     Note: shaman subpackage is not noarch. Please verify manually
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: shaman-1.0-5.fc29.x86_64.rpm
          shaman-1.0-5.fc29.src.rpm
shaman.x86_64: E: no-binary
shaman.x86_64: E: zero-length /usr/share/doc/shaman/THANKS
shaman.x86_64: W: desktopfile-without-binary /usr/share/applications/shaman.desktop /bin/shaman
shaman.src:21: W: macro-in-comment %global
shaman.src:21: W: macro-in-comment %{nil}
shaman.src:77: W: macro-in-%changelog %jpackage_script
shaman.src: E: specfile-error warning: Macro expanded in comment on line 21: %global debug_package %{nil}
2 packages and 0 specfiles checked; 3 errors, 4 warnings.

(In reply to Robert-André Mauchin from comment #14)

>    Your package should be noarch.
> 
> BuildArch: noarch

Fixed.

>  - Your .desktop file is linking to /bin/shaman: it should be
> /usr/bin/shaman:

Fixed.

>  - The THANKS file is empty, don't install it with %doc

Fixed.

>  - Remove the comment %global debug_package %{nil} and/or escape the macros
> which are in comment by doubling the %:
> 
> * Tue Jun 26 2018 Mohammed Isam <mohammed_isam1984> 1.0-5
> - Fixed the spec file (added %%jpackage_script BuildRequires clause)

Removed.

Spec URL: https://mohammedisam.fedorapeople.org/shaman.spec
SRPM URL: https://mohammedisam.fedorapeople.org/shaman-1.1-1.fc28.src.rpm

Package approved.

(In reply to Robert-André Mauchin from comment #17)
> Package approved.

Awesome! Thanks!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/shaman

shaman-1.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f10bf61fa

shaman-1.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f10bf61fa

shaman-1.1-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-25684bbf76

shaman-1.1-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-25684bbf76

shaman-1.1-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.