Bug 158558

Summary:	3 * missing return statement
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	cryptsetup	Assignee:	Bill Nottingham <notting>
Status:	CLOSED UPSTREAM	QA Contact:	Bill Nottingham <notting>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	agk, rvokal
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-05-23 17:00:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-05-23 15:40:24 UTC

Description of problem:

I just tried to compile package cryptsetup-luks-1.0-1 from Redhat
Fedora Core development tree with the most excellent Intel C
compiler.

The compiler said

keyencryption.c(59): warning #1011: missing return statement at end of non-void
function "clear_mapping"
setup.c(64): warning #1011: missing return statement at end of non-void function
"setup_leave"
setup.c(684): warning #1011: missing return statement at end of non-void
function "crypt_luksDelKey"

I've checked the source code in each case, and I recommend adding
return statements into each of the three routines.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Bill Nottingham 2005-05-23 17:00:17 UTC

Sent upstream.