Bug 1585587

Summary:	Review Request: perl-PPIx-QuoteLike - Parse Perl string literals and string-literal-like things
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review, paul
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-PPIx-QuoteLike-0.005-1.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-04 13:34:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1585179

Description Petr Pisar 2018-06-04 07:24:26 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-PPIx-QuoteLike/perl-PPIx-QuoteLike.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-PPIx-QuoteLike/perl-PPIx-QuoteLike-0.005-1.fc29.src.rpm
Description:
This Perl class parses Perl string literals and things that are reasonably
like string literals. Its real reason for being is to find interpolated
variables for Perl::Critic policies and similar code.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-06-04 08:32:00 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-PPIx-QuoteLike-0.005-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(PPI::Document) >= 1.117
      1 perl(PPI::Dumper) >= 1.117
      1 perl(PPIx::QuoteLike)
      1 perl(PPIx::QuoteLike::Constant)
      1 perl(PPIx::QuoteLike::Token)
      1 perl(PPIx::QuoteLike::Token::Control)
      1 perl(PPIx::QuoteLike::Token::Delimiter)
      1 perl(PPIx::QuoteLike::Token::Interpolation)
      1 perl(PPIx::QuoteLike::Token::String)
      1 perl(PPIx::QuoteLike::Token::Structure)
      1 perl(PPIx::QuoteLike::Token::Unknown)
      1 perl(PPIx::QuoteLike::Token::Whitespace)
      1 perl(PPIx::QuoteLike::Utils)
      1 perl(re)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-PPIx-QuoteLike-0.005-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(PPIx::QuoteLike) = 0.005
      1 perl-PPIx-QuoteLike = 0.005-1.fc29
      1 perl(PPIx::QuoteLike::Constant) = 0.005
      1 perl(PPIx::QuoteLike::Dumper) = 0.005
      1 perl(PPIx::QuoteLike::Token) = 0.005
      1 perl(PPIx::QuoteLike::Token::Control) = 0.005
      1 perl(PPIx::QuoteLike::Token::Delimiter) = 0.005
      1 perl(PPIx::QuoteLike::Token::Interpolation) = 0.005
      1 perl(PPIx::QuoteLike::Token::String) = 0.005
      1 perl(PPIx::QuoteLike::Token::Structure) = 0.005
      1 perl(PPIx::QuoteLike::Token::Unknown) = 0.005
      1 perl(PPIx::QuoteLike::Token::Whitespace) = 0.005
      1 perl(PPIx::QuoteLike::Utils) = 0.005
Binary provides are Ok.

$ rpmlint ./perl-PPIx-QuoteLike*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Paul Howarth 2018-06-04 08:44:32 UTC

*** Bug 1585625 has been marked as a duplicate of this bug. ***

Comment 3 Gwyn Ciesla 2018-06-04 12:50:27 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-PPIx-QuoteLike

Comment 4 Petr Pisar 2018-06-04 13:34:08 UTC

Thank you for the review and the repository.