Bug 1586346

Summary:	rsyncd.service fails to start at boot if address is configured
Product:	[Fedora] Fedora	Reporter:	Carl George 🤠 <carlwgeorge>
Component:	rsync	Assignee:	Michal Ruprich <mruprich>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	code, luhliari, mruprich, ssorce
Target Milestone:	---	Keywords:	Reproducer
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rsync-3.1.3-5.fc29 rsync-3.1.3-4.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1667436 (view as bug list)		Environment:
Last Closed:	2019-01-04 02:57:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Carl George 🤠 2018-06-06 03:39:30 UTC

Description of problem:
The rsyncd service is not configured to start after the network target.  Normally this doesn't appear to cause an issue (binding to 0.0.0.0 and ::), but if you configure rsyncd to bind to a specific IP address, it will fail to start at boot when it tries to bind to the IP before the network is online.  Ideally, I think rsyncd.service should include the directive `After=network.target`.

Version-Release number of selected component (if applicable):
This affects all versions of Fedora.
rsync-daemon-3.1.3-2.fc27.noarch
rsync-daemon-3.1.3-3.fc28.noarch

Steps to Reproduce:
1. add `address = x.x.x.x` to /etc/rsyncd.conf to limit the rsync daemon to a specific IP address
2. systemctl --enable rsyncd
3. reboot

Actual results:
Service fails to start.

Expected results:
Service starts at boot.

Comment 1 Michal Ruprich 2018-12-19 14:32:22 UTC

What worked for me was this added to Unit section:

Wants=network-online.target
After=network-online.target

Comment 2 Fedora Update System 2019-01-02 10:40:34 UTC

rsync-3.1.3-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6ae95964c0

Comment 3 Fedora Update System 2019-01-02 10:40:37 UTC

rsync-3.1.3-5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0bdac62953

Comment 4 Fedora Update System 2019-01-03 04:00:22 UTC

rsync-3.1.3-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6ae95964c0

Comment 5 Fedora Update System 2019-01-03 05:07:39 UTC

rsync-3.1.3-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0bdac62953

Comment 6 Fedora Update System 2019-01-04 02:57:09 UTC

rsync-3.1.3-5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2019-01-22 01:34:37 UTC

rsync-3.1.3-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.