Bug 158641

Summary: liboil fails to rebuild with gcc4
Product: [Fedora] Fedora Reporter: Jeremy Katz <katzj>
Component: liboilAssignee: Matthias Saou <matthias>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideKeywords: Patch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-05-25 17:28:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 157183    
Attachments:
Description Flags
fix gcc compilation failure none

Description Jeremy Katz 2005-05-24 15:13:02 UTC
Fails on i386, failure log under
http://extras64.linux.duke.edu/failed/development/liboil/0.3.0-3/i386/

Comment 1 Tom "spot" Callaway 2005-05-24 20:33:38 UTC
Created attachment 114801 [details]
fix gcc compilation failure

This patch does two things:

1. Fixes liboil to use CFLAGS as defined at build time rather than just
ignoring them and using its own arbitrary set.

2. Adds -m3dnow to the Makefile only for the one file that needs to be compiled
with that option.

With this patch, liboil builds in rawhide.

Comment 2 Matthias Saou 2005-05-25 17:28:56 UTC
Thanks a lot. I've now updated to 0.3.2 too, as it also rebuilds fine with your
patch.