Bug 158757

Summary: missing return statement
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: etherealAssignee: Radek Vokál <rvokal>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-05-25 14:11:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2005-05-25 13:38:35 UTC
Description of problem:
I just tried to compile package ethereal-0.10.11-1 from Redhat Fedora
Core development tree with the most excellent Intel C compiler.

The compiler said

1.

packet-ndmp.c(1657): warning #1011: missing return statement at end of non-void
function "dissect_data_connect_msg"

The source code is

static int
dissect_data_connect_msg(tvbuff_t *tvb, int offset, packet_info *pinfo,
    proto_tree *tree, guint32 seq _U_)
{
        /* ndmp addr */
        offset=dissect_ndmp_addr(tvb, offset, pinfo, tree);
}

Suggest add return statement to the end of the routine.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Radek Vokál 2005-05-25 14:11:53 UTC
Please, if you don't have a crash with the above code report to upstream -
http://bugs.ethereal.com/bugzilla/