Bug 1588465

Summary:	[DR] Log file not created for disaster validation
Product:	[oVirt] ovirt-ansible-collection	Reporter:	Kevin Alon Goldblatt <kgoldbla>
Component:	disaster-recovery	Assignee:	Maor <mlipchuk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	1.1.0	CC:	mlipchuk, tnisan
Target Milestone:	ovirt-4.2.5	Flags:	rule-engine: ovirt-4.2+
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:	DR
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-31 15:24:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kevin Alon Goldblatt 2018-06-07 11:59:13 UTC

Description of problem:
When running sudo /usr/share/ansible/roles/oVirt.disaster-recovery/files/ovirt-dr validate and an error occurs a log files is displayed as been generated but does not exist

 Log file: '/tmp/ovirt-dr-1528372234067.log'
[Validate Mapping File] Validate variable mapping file for oVirt ansible disaster recovery
[Validate Mapping File] Var File: '/var/lib/ovirt-ansible-disaster-recovery/mapping_vars.yml'
[Validate Mapping File] Please provide vault password for file 'ovirt_passwords.yml' (For plain file, please press enter): 123456
[Validate Mapping File] mapping dr_affinity_group_mappings is empty in var file
[Validate Mapping File] mapping dr_affinity_label_mappings is empty in var file
[Validate Mapping File] Can not read passwords from vault. Will try to read as plain file.
[Validate Mapping File] Can not read passwords from file
[Validate Mapping File] Connection to setup has failed. Please check your cradentials: 
[Validate Mapping File]  URL: https://storage-ge-10.scl.lab.tlv.redhat.com/ovirt-engine/api
[Validate Mapping File]  USER: admin@internal
[Validate Mapping File]  CA file: /home/kgoldbla/pki-resource
[Validate Mapping File] Failed to validate variable mapping file for oVirt ansible disaster recovery
[kgoldbla@dhcp-4-100 files]$ less /tmp/ovirt-dr-1528372234067.log
/tmp/ovirt-dr-1528372234067.log: No such file or directory
[kgoldbla@dhcp-4-100 files]$ sudo less /tmp/ovirt-dr-1528372234067.log
/tmp/ovirt-dr-1528372234067.log: No such file or directory


Version-Release number of selected component (if applicable):
ovirt-ansible-disaster-recovery-1.1.0-1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1.sudo /usr/share/ansible/roles/oVirt.disaster-recovery/files/ovirt-dr validate 
2.An error is reported as above and a log file is displayed in the error. When trying to view the log file it does not exist
3.

Actual results:
An error is reported as above and a log file is displayed in the error. When trying to view the log file it does not exist

Expected results:
Log file should be created and accessible

Additional info:

Comment 1 Maor 2018-06-07 12:34:16 UTC

validate should not have log file since the validate process suppose to be intitive to the user.
The log file should be removed

Comment 2 Sandro Bonazzola 2018-06-29 16:00:21 UTC

Has this been included in a build? I didn't see a build attached to 4.2.5 RC1 release.

Comment 3 Maor 2018-06-29 18:48:51 UTC

Hi Sandro,

This fix was not included in the build, since it was a minor issue and I plan to include this with other fixes that should be merged soon

Comment 4 Kevin Alon Goldblatt 2018-07-26 16:06:33 UTC

Verified with the following code:
---------------------------------------
ovirt-ansible-disaster-recovery-1.1.1-1.el7ev.noarch

Verified with the following scenario:
----------------------------------------
1. Ovirt-dr validate
2. enter password for source and destination  >>>>> Validation is successfull
Error output is displayed when relevant. No error log is used

Moving to VERIFIED!

Comment 5 Sandro Bonazzola 2018-07-31 15:24:55 UTC

This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.