Bug 1589270

Summary: ovirt-engine-setup-plugin-ovirt-engine %pre fails on Fedora 28
Product: [oVirt] ovirt-engine Reporter: Sandro Bonazzola <sbonazzo>
Component: Packaging.rpmAssignee: Gal Zaidman <gzaidman>
Status: CLOSED UPSTREAM QA Contact: Lukas Svaty <lsvaty>
Severity: high Docs Contact:
Priority: high    
Version: 4.3.0CC: boeroboy, bugs, lsvaty
Target Milestone: ovirt-4.3.0Flags: rule-engine: ovirt-4.3+
rule-engine: blocker+
Target Release: 4.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: No Doc Update
Doc Text:
undefined
 Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-16 08:05:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1460625    

Description Sandro Bonazzola 2018-06-08 14:58:26 UTC 
In ovirt-engine spec file we have:

   %pre setup-plugin-ovirt-engine
   %ovirt_create_user_vdsm

this works fine on EL7 bug on Fedora 28 the generated script looks like:

  set -x
  getent group kvm >/dev/null || groupadd -r -g 36 kvm;
  getent passwd vdsm >/dev/null || useradd -r -u 36 -g kvm -c "Node -s /sbin/nologin -d Virtualization vdsm

This seems like 
  "%{vdsm_description}"
is resolved in 
  Node Virtualization Manager
instead of
  "Node Virtualization Manager"

causing the command to fail
Comment 1 Sandro Bonazzola 2018-06-08 15:06:53 UTC 
Note that the failure is due to the unmatched " but the root cause is the wrong macro expansion.
Comment 2 Sandro Bonazzola 2018-06-08 15:09:55 UTC 
Workaround to be able to continue while this bug is fixed:
# dnf download ovirt-engine-setup-plugin-ovirt-engine
# rpm -ivh --noscripts ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch.rpm
Comment 3 Sandro Bonazzola 2018-06-12 14:14:06 UTC 
*** Bug 1590302 has been marked as a duplicate of this bug. ***