Bug 1589789

Summary: Deleting a sync plan does not stop syncing repos from it
Product: Red Hat Satellite Reporter: Pavel Moravec <pmoravec>
Component: RepositoriesAssignee: Stephen Benjamin <stbenjam>
Status: CLOSED ERRATA QA Contact: Peter Ondrejka <pondrejk>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.3.1CC: jbhatia, ktordeur, pcreech, pmoravec
Target Milestone: 6.4.0Keywords: Regression, Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: tfm-rubygem-katello-3.7.0.rc1.2-0.1.rc1.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-16 19:35:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Moravec 2018-06-11 12:00:59 UTC
Description of problem:
When I delete a sync plan with associated product(s) and repo(s), the pulp repos are still synced underneath like the plan would still exist.

The cause is, katello does not delete the sync plan but updates it, since pulp_rest debugs show:

2018-06-11 13:40:29  [katello/pulp_rest] [D] RestClient.put "https://pmoravec-sat63.gsslab.brq2.redhat.com/pulp/api/v2/repositories/a89a3c32-9c85-40e8-b22c-0cf3411911be/importers/yum_importer/schedules/sync/5b1ce0b3a0ad7a17858344d9/", "{\"schedule\":\"2018-06-11T14:00:00+02:00/PT1H\",\"enabled\":true}", "Accept"=>"*/*; q=0.5, application/xml", "Accept-Encoding"=>"gzip, deflate", "Content-Length"=>"60", "accept"=>"application/json", "content_type"=>"application/json"


See e.g. enabled:true. Rather DELETE op per https://docs.pulpproject.org/dev-guide/integration/rest-api/repo/sync.html#deleting-a-scheduled-sync should be used.

And pulp mongo_database really still has a record in scheduled_calls collection.

Even removing a sync plan that has not been executed is affected the same.



Version-Release number of selected component (if applicable):
Sat 6.3.1
tfm-rubygem-katello-3.4.5.64-1.el7sat.noarch


How reproducible:
100%


Steps to Reproduce:
1. Create a sync plan, add some product there
2. Delete the sync plan (even before it is executed for the 1st time)
3. Create a sync plan, add some product there, wait for its 1st (or 2nd or even more, if patient) execution
4. Delete the sync plan
5. Check on next sync plans expected execution if underlying repos will be synced / Monitor -> Tasks will have " Scheduled Synchronization repository .." tasks


Actual results:
5. Both sync plans from 1 and 3 steps are still executed, despite they have been deleted.


Expected results:
5. no further execution of sync plans after their removal


Additional info:

Comment 3 Pavel Moravec 2018-06-14 06:17:02 UTC
Indeed, this is a regression.

6.2.14 deletes all sync plans properly in all scenarios described in this BZ.

Comment 5 Stephen Benjamin 2018-06-25 18:39:44 UTC
Created redmine issue https://projects.theforeman.org/issues/24068 from this bug

Comment 6 Satellite Program 2018-06-28 16:00:55 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/24068 has been resolved.

Comment 7 Peter Ondrejka 2018-07-10 12:29:41 UTC
Verified on Sat 6.4 snap 11, sync plans are no longer executed after they are deleted

Comment 8 Bryan Kearney 2018-10-16 19:35:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927