Bug 1589792

Summary:	ceph-osd: set 'openstack_keys_tmp' only when 'openstack_config' is defined.
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Sébastien Han <shan>
Component:	Ceph-Ansible	Assignee:	Sébastien Han <shan>
Status:	CLOSED ERRATA	QA Contact:	ceph-qe-bugs <ceph-qe-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.1	CC:	aschoen, ceph-eng-bugs, ceph-qe-bugs, gmeno, hnallurv, kdreyer, nthomas, sankarshan, vpoliset
Target Milestone:	rc
Target Release:	3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	RHEL: ceph-ansible-3.1.0-0.1.rc9.el7cp Ubuntu: ceph-ansible_3.1.0~rc9-2redhat1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-26 18:21:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sébastien Han 2018-06-11 12:03:08 UTC

Description of problem:

"set_fact openstack_keys_tmp" is a task which was added for backward compatibility since module ceph_key  has been introduced, this task should be run only if openstack_config is True.


How reproducible:
Deploy a cluster with openstack_config: False


Actual results:
the task "set_fact openstack_keys_tmp" is run while it's not necessary.


Expected results:
the task "set_fact openstack_keys_tmp" is skipped.


Additional info:

Comment 7 subhash 2018-06-14 16:09:27 UTC

Have deployed the cluster with following all.yml vars set and the task set_fact openstack_keys_tmp is being skipped,will move it to verified state once it is ON_QA.

---
dummy:
fetch_directory: ~/ceph-ansible-keys
configure_firewall: True
ceph_origin: distro
ceph_repository: rhcs
monitor_interface: eno1 # "{{ ceph_mon_docker_interface if ceph_mon_docker_interface != 'interface' else 'interface' }}" # backward compatibility with stable-2.2, will disappear in stable 3.1
public_network: 10.8.128.0/21 #"{{ ceph_mon_docker_subnet if ceph_mon_docker_subnet != '0.0.0.0/0' else '0.0.0.0/0' }}" # backward compatibility with stable-2.2, will disappear in stable 3.1
openstack_config: false

Component version:
[ubuntu@magna046 ceph-ansible]$ rpm -qa | grep ansible
ceph-ansible-3.1.0-0.1.rc9.el7cp.noarch
ansible-2.4.4.0-1.el7ae.noarch

Comment 9 subhash 2018-06-18 17:33:51 UTC

Version-Release number of selected component (if applicable):
RHEL: ceph-ansible-3.1.0-0.1.rc9.el7cp 
Ubuntu: ceph-ansible_3.1.0~rc9-2redhat1

Issue no longer seen on rhel and ubuntu.

Comment 11 errata-xmlrpc 2018-09-26 18:21:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2819