Bug 1590193

Summary:	/usr/sbin/gcron.py aborts with OSError
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	snapshot	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://retrace.fedoraproject.org/faf/reports/2085492/
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1590192	Environment:
Last Closed:	2018-10-23 15:11:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1559829, 1590192, 1590195

Description Niels de Vos 2018-06-12 07:47:52 UTC

+++ This bug was initially created as a clone of Bug #1590192 +++

Description of problem:

FAF reports https://retrace.fedoraproject.org/faf/reports/2085492/

Executable
    /usr/sbin/gcron.py 
Error name
    OSError 

Backtrace shows doJob in gcron.py on line 91.

Version-Release number of selected component (if applicable):
glusterfs-server 3.12.6-1.el7 and 3.12.9-1.el7

How reproducible:
Unknown

Comment 1 Worker Ant 2018-06-12 07:54:51 UTC

REVIEW: https://review.gluster.org/20236 (gcron: catch OSError as well as IOError) posted (#1) for review on master by Niels de Vos

Comment 2 Worker Ant 2018-06-12 07:55:49 UTC

REVIEW: https://review.gluster.org/20237 (gcron: create the lockfile if it is missing) posted (#1) for review on master by Niels de Vos

Comment 3 Worker Ant 2018-06-18 03:52:11 UTC

COMMIT: https://review.gluster.org/20236 committed in master by "Amar Tumballi" <amarts> with a commit message- gcron: catch OSError as well as IOError

In case os.open() fails because the file does not exist, an OSError is
raised. To prevent the script to abort uncleanly, catch the OSError in
addition to the IOError.

Change-Id: I48e5b23e17d63639cc33db51b4229249a9887880
Fixes: bz#1590193
Signed-off-by: Niels de Vos <ndevos>

Comment 4 Worker Ant 2018-06-18 04:06:40 UTC

COMMIT: https://review.gluster.org/20237 committed in master by "Amar Tumballi" <amarts> with a commit message- gcron: create the lockfile if it is missing

The lockfile for the job may not exist yet. If that is the case, it
should be created upon the first time it is accessed.

Change-Id: I4da2b3ecdb79cc63ed82cc7bfa026c8f08d4d043
Fixes: bz#1590193
Signed-off-by: Niels de Vos <ndevos>

Comment 5 Shyamsundar 2018-10-23 15:11:13 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/