Bug 1590195

Summary:	/usr/sbin/gcron.py aborts with OSError
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	snapshot	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.1	CC:	bugs, rkavunga
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://retrace.fedoraproject.org/faf/reports/2085492/
Whiteboard:
Fixed In Version:	4.1.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-20 09:17:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1590193
Bug Blocks:

Description Niels de Vos 2018-06-12 07:59:15 UTC

+++ This bug was initially created as a clone of Bug #1590193 +++

Description of problem:

FAF reports https://retrace.fedoraproject.org/faf/reports/2085492/

Executable
    /usr/sbin/gcron.py 
Error name
    OSError 

Backtrace shows doJob in gcron.py on line 91.

Version-Release number of selected component (if applicable):
glusterfs-server 3.12.6-1.el7 and 3.12.9-1.el7

How reproducible:
Unknown

--- Additional comment from Worker Ant on 2018-06-12 09:54:51 CEST ---

REVIEW: https://review.gluster.org/20236 (gcron: catch OSError as well as IOError) posted (#1) for review on master by Niels de Vos

--- Additional comment from Worker Ant on 2018-06-12 09:55:49 CEST ---

REVIEW: https://review.gluster.org/20237 (gcron: create the lockfile if it is missing) posted (#1) for review on master by Niels de Vos

Comment 1 Worker Ant 2018-06-18 07:30:35 UTC

REVIEW: https://review.gluster.org/20300 (gcron: create the lockfile if it is missing) posted (#1) for review on release-4.1 by Niels de Vos

Comment 2 Worker Ant 2018-06-18 13:20:00 UTC

REVIEW: https://review.gluster.org/20305 (gcron: catch OSError as well as IOError) posted (#1) for review on release-4.1 by Niels de Vos

Comment 3 Worker Ant 2018-06-20 17:38:44 UTC

COMMIT: https://review.gluster.org/20305 committed in release-4.1 by "Niels de Vos" <ndevos> with a commit message- gcron: catch OSError as well as IOError

In case os.open() fails because the file does not exist, an OSError is
raised. To prevent the script to abort uncleanly, catch the OSError in
addition to the IOError.

Change-Id: I48e5b23e17d63639cc33db51b4229249a9887880
Fixes: bz#1590195
Signed-off-by: Niels de Vos <ndevos>
(cherry picked from commit 26b52694feb04c98e6c9436bcd4e23e1687f0237)

Comment 4 Worker Ant 2018-06-20 17:39:08 UTC

COMMIT: https://review.gluster.org/20300 committed in release-4.1 by "Shyamsundar Ranganathan" <srangana> with a commit message- gcron: create the lockfile if it is missing

The lockfile for the job may not exist yet. If that is the case, it
should be created upon the first time it is accessed.

Change-Id: I4da2b3ecdb79cc63ed82cc7bfa026c8f08d4d043
Fixes: bz#1590195
Signed-off-by: Niels de Vos <ndevos>
(cherry picked from commit 7005b1a336e483ec150c2f924a618dcfe197db0b)