Bug 1590220
| Summary: | Hide rhv-upload option in virt-p2v client | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | mxie <mxie> | ||||||
| Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 7.6 | CC: | juzhou, mzhan, ptoscano, rjones, tzheng, xiaodwan | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | P2V | ||||||||
| Fixed In Version: | libguestfs-1.38.2-9.el7 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-10-30 07:45:56 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
ACK, mistake in the regular expression which matches the output names. I'll post a tiny fix shortly. I am working on a second version of this patch so please ignore comment 3 for now. I posted an updated patch to solve the simple part of this problem. However -o rhv-upload is not going to work unless we also add the many other -o* options needed to the GUI. I'm working on this at the moment. The first part of this is upstream in 3886a113f231f7b38a89333491888c4d9a0c19da But as noted in comment 5, there is (much) more to follow to truly fix this. Verify the bug with below builds: virt-p2v-1.38.2-2.el7.noarch virt-v2v-1.38.2-6.el7.x86_64 libguestfs-1.38.2-6.el7.x86_64 Steps: 1.Boot host into virt-p2v client 2.Input virt-v2v conversion info and pass "test connection" 3.At inputting conversion info interface. Check the options in "Output to (-o)", rhv is not duplicate Result: There is no duplicate options listed in "Output to (-o)", so move the bug from ON_QA to VERIFIED Sorry this bug was moved to ON_QA incorrectly. It's still under development, so moving back to ASSIGNED. sorry, my mistake Verify the bug with builds virt-v2v-1.38.2-9.el7.x86_64 libguestfs-1.38.2-9.el7.x86_64 virt-p2v-maker-1.38.2-9.el7.x86_64 Steps: 1.Build virt-p2v bootable USB key with virt-p2v-maker # virt-p2v-make-disk -o /dev/sdb rhel-7.5 [ 3.7] Downloading: http://file.rdu.redhat.com/~rjones/builder/rhel-7.5.xz [ 4.4] Planning how to build this image .... [1269.6] Finishing off Output file: /dev/sdb Output size: 14.9G Output format: raw Total usable space: 14.3G Free space: 12.9G (89%) 2.P2v bootable USB key can be built successfully, but can not lanuch p2v client pls refer to screenshot 'p2v-usb-key' Hi Pino, According to step2, there is problem with virt-p2v bootable USB key, could you please help to check this problem and build latest virt-p2v iso on brewweb ? I will verify the bug with p2v iso again, meanwhile, it will be convenient for us to test virt-p2v on physical machine with iso file, thanks Created attachment 1470475 [details]
p2v-usb-key.png
(In reply to mxie from comment #18) > According to step2, there is problem with virt-p2v bootable USB key, > could you please help to check this problem and build latest virt-p2v iso on > brewweb ? This is a separate issue, unrelated to this bug... please open new bugs for different issues, otherwise it is hard for us to track bugs. The latest virt-p2v is already available in brew, did you test it? (In reply to Pino Toscano from comment #20) > (In reply to mxie from comment #18) > > According to step2, there is problem with virt-p2v bootable USB key, > > could you please help to check this problem and build latest virt-p2v iso on > > brewweb ? > > This is a separate issue, unrelated to this bug... please open new bugs for > different issues, otherwise it is hard for us to track bugs. > > The latest virt-p2v is already available in brew, did you test it? I saw the latest virt-p2v iso is still virt-p2v-1.38.2-2.el7 in brew (In reply to mxie from comment #21) > (In reply to Pino Toscano from comment #20) > > (In reply to mxie from comment #18) > > > According to step2, there is problem with virt-p2v bootable USB key, > > > could you please help to check this problem and build latest virt-p2v iso on > > > brewweb ? > > > > This is a separate issue, unrelated to this bug... please open new bugs for > > different issues, otherwise it is hard for us to track bugs. > > > > The latest virt-p2v is already available in brew, did you test it? > > I saw the latest virt-p2v iso is still virt-p2v-1.38.2-2.el7 in brew That is the latest version available. There is no match between the libguestfs version, and the version of the virt-p2v ISO, see the explanation in bug 1597479. Verify the bug with builds: virt-v2v-1.38.2-10.el7.x86_64 libguestfs-1.38.2-10.el7.x86_64 virt-p2v-1.38.2-3.el7.iso Steps: 1.Boot host into virt-p2v client 2.Input virt-v2v conversion info and pass "test connection" 3.At inputting conversion info interface. Check the options in "Output to (-o)", Result: There is no "rhv-upload" listed in "Output to (-o)", so move the bug from ON_QA to VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:3021 |
Created attachment 1450357 [details] output-options.png Description of problem: Two rhv options are listed in virt-p2v client Version-Release number of selected component (if applicable): virt-p2v-1.38.2-1.el7.iso virt-v2v-1.38.2-3.el7.x86_64 libguestfs-1.38.2-3.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1.Boot host into virt-p2v client 2.Input virt-v2v conversion server info and pass the test connection 3.At inputting conversion info interface. check the output options but found rhv options are duplicate,pls refer to screenshot Actual results: As above description Expected Results: One of duplicated options "rhv" should be rhv-upload Additional info: