Bug 1590265

Summary:	ip*tables.service improvements
Product:	Red Hat Enterprise Linux 8	Reporter:	Marcos Mello <marcosfrm>
Component:	iptables	Assignee:	Phil Sutter <psutter>
Status:	CLOSED ERRATA	QA Contact:	Tomas Dolezal <todoleza>
Severity:	low	Docs Contact:
Priority:	low
Version:	8.1	CC:	iptables-maint-list, jmaxwell, rkhan, sukulkar, todoleza
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	iptables-1.8.4-11.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 01:54:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1807630, 1825061

Description Marcos Mello 2018-06-12 10:31:05 UTC

ip*tables.service improvements

- WantedBy=basic.target with DefaultDependencies=yes (implicit default) is broken config. Use WantedBy=multi-user.target (like firewalld, NetworkManager).
  See https://lists.freedesktop.org/archives/systemd-devel/2016-July/037242.html

- After=syslog.target is unnecessary. It is not even provided since systemd 198. Remove it.
  See https://github.com/systemd/systemd/commit/5d4caf565471ff3401bd9b53aa814c8545a18a93

- systemd 214+ has a passive target designed for firewalls: network-pre.target. Add Before=network-pre.target / Wants=network-pre.target into [Unit] section.
  See https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

Comment 2 Marcos Mello 2018-06-12 11:55:55 UTC

One more thing. iptables.service has Before=ip6tables.service and ip6tables.service has After=iptables.service. This is redundant and can be simplified dropping one of them (I would remove Before=ip6tables.service from iptables.service, keeping After=iptables.service in ip6tables.service). Note: entirely optional.

Comment 3 Phil Sutter 2019-06-05 09:58:58 UTC

Hi,

Thanks for your unit file review and the suggested improvements. Given that the
service works fine just the way it is, I'll treat this as an enhancement and
move the ticket to RHEL8. Feel free to speak up in case the unit is problematic
for you in RHEL7, i.e., there is something we should fix.

Thanks, Phil

Comment 12 errata-xmlrpc 2020-11-04 01:54:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (iptables bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4518