Bug 1590302

Working with master-snapshot 4.3 yum repo, there is a bug in packaging.

A variable substitution on line 122 includes a leading double quote but not a close quote which fails the rpm scriptlet.  It looks like a newline is making it into user description variable during packaging and there is currently no way to install ovirt-engine in master.

https://github.com/oVirt/ovirt-engine/blob/master/ovirt-engine.spec.in#L122





~> sudo dnf install --rpmverbosity=debug ovirt-engine-setup-plugin-ovirt-engine-0:4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch
Last metadata expiration check: 0:07:02 ago on Tue 12 Jun 2018 07:31:44 AM EDT.
Dependencies resolved.
========================================================================================================================================================================================
 Package                                              Arch                 Version                                                            Repository                           Size
========================================================================================================================================================================================
Installing:
 ovirt-engine-setup-plugin-ovirt-engine               noarch               4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28                ovirt-master-snapshot               177 k

Transaction Summary
========================================================================================================================================================================================
Install  1 Package

Total download size: 177 k
Installed size: 824 k
Is this ok [y/N]: y
Downloading Packages:
ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch.rpm                                                   237 kB/s | 177 kB     00:00    
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                                                                   164 kB/s | 177 kB     00:01     
Running transaction check
Transaction check succeeded.
Running transaction test
fdio:       6 reads,    52020 total bytes in 0.000021 secs
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                1/1 
  Running scriptlet: ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch                                                              1/1 
fdio:       2 writes,      169 total bytes in 0.000023 secs
D: closed   db index       /var/lib/rpm/Packages
D: closed   db index       /var/lib/rpm/Enhancename
D: closed   db index       /var/lib/rpm/Supplementname
D: closed   db index       /var/lib/rpm/Suggestname
D: closed   db index       /var/lib/rpm/Recommendname
D: closed   db index       /var/lib/rpm/Transfiletriggername
D: closed   db index       /var/lib/rpm/Filetriggername
D: closed   db index       /var/lib/rpm/Sha1header
D: closed   db index       /var/lib/rpm/Sigmd5
D: closed   db index       /var/lib/rpm/Installtid
D: closed   db index       /var/lib/rpm/Dirnames
D: closed   db index       /var/lib/rpm/Triggername
D: closed   db index       /var/lib/rpm/Obsoletename
D: closed   db index       /var/lib/rpm/Conflictname
D: closed   db index       /var/lib/rpm/Providename
D: closed   db index       /var/lib/rpm/Requirename
D: closed   db index       /var/lib/rpm/Group
D: closed   db index       /var/lib/rpm/Basenames
D: closed   db index       /var/lib/rpm/Name
D: closed   db environment /var/lib/rpm
D: opening  db environment /var/lib/rpm cdb:0x401
D: opening  db index       /var/lib/rpm/Packages (none) mode=0x42
D: sanity checking 1 elements
D: opening  db index       /var/lib/rpm/Name (none) mode=0x42
D: Plugin: calling hook tsm_pre in selinux plugin
D: selabel_open: (/etc/selinux/targeted/contexts/files/file_contexts) 
D: Plugin: calling hook tsm_pre in systemd_inhibit plugin
D: System shutdown blocked (fd 54)
D: running pre-transaction scripts
D: computing 301 file fingerprints
D: opening  db index       /var/lib/rpm/Basenames (none) mode=0x42
D: opening  db index       /var/lib/rpm/Group (none) mode=0x42
D: opening  db index       /var/lib/rpm/Requirename (none) mode=0x42
D: opening  db index       /var/lib/rpm/Providename (none) mode=0x42
D: opening  db index       /var/lib/rpm/Conflictname (none) mode=0x42
D: opening  db index       /var/lib/rpm/Obsoletename (none) mode=0x42
D: opening  db index       /var/lib/rpm/Triggername (none) mode=0x42
D: opening  db index       /var/lib/rpm/Dirnames (none) mode=0x42
D: opening  db index       /var/lib/rpm/Installtid (none) mode=0x42
D: opening  db index       /var/lib/rpm/Sigmd5 (none) mode=0x42
D: opening  db index       /var/lib/rpm/Sha1header (none) mode=0x42
D: opening  db index       /var/lib/rpm/Filetriggername (none) mode=0x42
D: opening  db index       /var/lib/rpm/Transfiletriggername (none) mode=0x42
D: opening  db index       /var/lib/rpm/Recommendname (none) mode=0x42
D: opening  db index       /var/lib/rpm/Suggestname (none) mode=0x42
D: opening  db index       /var/lib/rpm/Supplementname (none) mode=0x42
D: opening  db index       /var/lib/rpm/Enhancename (none) mode=0x42
D: computing file dispositions
D: 0x0000fd00     4096      2250344      6427736 /
D: ========== +++ ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28 noarch-linux 0x0
D: ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch: Header SHA1 digest: OK
D: ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch: Header SHA256 digest: OK
D:   install: ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch has 301 files
D: Plugin: calling hook psm_pre in selinux plugin
D: %prein(ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch): scriptlet start
D: %prein(ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch): execv(/bin/sh) pid 9230
D: Plugin: calling hook scriptlet_fork_post in selinux plugin
D: setexecfilecon: (/bin/sh) 
+ getent group kvm
/var/tmp/rpm-tmp.tDyMQw: line 5: unexpected EOF while looking for matching `"'
/var/tmp/rpm-tmp.tDyMQw: line 6: syntax error: unexpected end of file
D: %prein(ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch): waitpid(9230) rc 9230 status 200
error: %prein(ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch) scriptlet failed, exit status 2
Error in PREIN scriptlet in rpm package ovirt-engine-setup-plugin-ovirt-engine
Error in PREIN scriptlet in rpm package ovirt-engine-setup-plugin-ovirt-engine
fdio:       6 reads,    52020 total bytes in 0.000022 secs
ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch was supposed to be installed but is not!
  Verifying        : ovirt-engine-setup-plugin-ovirt-engine-4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28.noarch                                                              1/1 

Failed:
  ovirt-engine-setup-plugin-ovirt-engine.noarch 4.3.0-0.0.master.20180608115732.gita4bbacb7277.fc28                                                                                     

Error: Transaction failed

~> sudo cat /var/tmp/rpm-tmp.tDyMQw
set -x


getent group kvm >/dev/null || groupadd -r -g 36 kvm; 
getent passwd vdsm >/dev/null || useradd -r -u 36 -g kvm -c "Node -s /sbin/nologin -d Virtualization vdsm⏎                                                                              
~>