Bug 1590655

Summary:	Excessive logging in posix_check_internal_writes() due to NULL dict
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	posix	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1590657 (view as bug list)		Environment:
Last Closed:	2018-10-23 15:11:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1590657

Description Krutika Dhananjay 2018-06-13 07:01:46 UTC

Description of problem:

I was running some write-intensive tests on my volume, and in a matter of 2 hrs, the 50GB space in my root partition was filled up. Turns out it's due to excessive logging in bricks - specifically in posix write when posix_check_internal_writes() does dict_get() before performing NULL-check on the dict.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-06-13 07:03:59 UTC

REVIEW: https://review.gluster.org/20250 (storage/posix: Fix excessive logging in WRITE fop path) posted (#1) for review on master by Krutika Dhananjay

Comment 2 Worker Ant 2018-06-13 12:31:37 UTC

COMMIT: https://review.gluster.org/20250 committed in master by "jiffin tony Thottan" <jthottan> with a commit message- storage/posix: Fix excessive logging in WRITE fop path

I was running some write-intensive tests on my volume, and in a matter
of 2 hrs, the 50GB space in my root partition was exhausted. On inspecting
further, figured that excessive logging in bricks was the cause -
specifically in posix write when posix_check_internal_writes() does
dict_get() without a NULL-check on xdata.

Change-Id: I89de57a3a90ca5c375e5b9477801a9e5ff018bbf
fixes: bz#1590655
Signed-off-by: Krutika Dhananjay <kdhananj>

Comment 3 Shyamsundar 2018-10-23 15:11:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/