Bug 1590891

Summary: Accessing hosted engine page without gdeploy installed generates error
Product: [oVirt] cockpit-ovirt Reporter: Phillip Bailey <phbailey>
Component: GdeployAssignee: Phillip Bailey <phbailey>
Status: CLOSED CURRENTRELEASE QA Contact: bipin <bshetty>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 0.11.26CC: bshetty, bugs, sasundar
Target Milestone: ovirt-4.2.5Flags: rule-engine: ovirt-4.2?
sasundar: planning_ack?
rule-engine: devel_ack+
sasundar: testing_ack+
Target Release: 0.11.29   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.29-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-31 15:27:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1596277    

Description Phillip Bailey 2018-06-13 15:28:23 UTC
Description of problem:
If the user accesses the hosted engine landing page and doesn't have gdeploy installed, a console error is generated and "Ooops!" is displayed in the top bar of the Cockpit UI.

Version-Release number of selected component (if applicable):
cockpit-ovirt-0.11.28-1.20180606.gite0fb57a.el7

How reproducible:
100%

Steps to Reproduce:
1. Open the hosted engine landing page without gdeploy installed
2. Open the developer console

Actual results:
"Oops!" is shown in the top bar and the following error is shown in the console:

Uncaught TypeError: Cannot read property 'split' of undefined
    at Object.isGdeploySupportVdo (app.js:4343)
    at Function.<anonymous> (app.js:4332)
    at P (cockpit.js:874)
    at cockpit.js:886
    at j (cockpit.js:803)


Expected results:
No error is displayed and "Oops!" isn't shown in the top bar.

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2018-06-13 15:28:53 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 SATHEESARAN 2018-07-18 07:26:50 UTC
Tested with cockpit-ovirt-dashboard-0.11.30 with the following steps:

1. Removed gdeploy from the RHVH node
2. Started hyperconverged setup

Observed the error with reasonable text message that gdeploy is not available and there are neither uncaught exceptions nor 'oops' message on the title bar

Comment 3 Sandro Bonazzola 2018-07-31 15:27:45 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.