Bug 1591109

Summary:	Review Request: perl-Tie-Hash-MultiValue - Store multiple values per key
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Tie-Hash-MultiValue-1.02-1.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-14 13:21:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1591111

Description Petr Pisar 2018-06-14 05:49:38 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Tie-Hash-MultiValue/perl-Tie-Hash-MultiValue.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Tie-Hash-MultiValue/perl-Tie-Hash-MultiValue-1.02-1.fc29.src.rpm
Description: Tie::Hash::MultiValue Perl module allows you to have hashes which store their
values in anonymous arrays, appending any new value to the already-existing
ones.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-06-14 08:53:28 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Tie-Hash-MultiValue-1.02-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(strict)
      1 perl(Tie::Hash) >= 1
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Tie-Hash-MultiValue-1.02-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Tie::Hash::MultiValue) = 1.02
      1 perl-Tie-Hash-MultiValue = 1.02-1.fc29
Binary provides are Ok.

$ rpmlint ./perl-Tie-Hash-MultiValue*
perl-Tie-Hash-MultiValue.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Tie-Hash-MultiValue/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
Rpmlint is ok. The error was reported to upstream.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2018-06-14 13:09:14 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Tie-Hash-MultiValue

Comment 3 Petr Pisar 2018-06-14 13:21:34 UTC

Thank you for the review and the repository.