Bug 1591111
Summary: | Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jplesnik, package-review |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Hash-AutoHash-1.17-1.fc29 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-06-14 13:40:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1591109 | ||
Bug Blocks: | 1591116 |
Description
Petr Pisar
2018-06-14 05:59:18 UTC
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are almost ok FIX: Please remove duplicity from build-requires - List::MoreUtils - Scalar::Util $ rpm -qp --requires perl-Hash-AutoHash-1.17-1.fc29.noarch.rpm | sort | uniq -c 1 perl(Carp) >= 1.2 1 perl(List::MoreUtils) >= 0.33 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Tie::Hash) >= 1.04 1 perl(Tie::ToObject) >= 0.03 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Hash-AutoHash-1.17-1.fc29.noarch.rpm | sort | uniq -c 1 perl(Hash::AutoHash) = 1.17 1 perl-Hash-AutoHash = 1.17-1.fc29 1 perl(Hash::AutoHash::alias) 1 perl(Hash::AutoHash::helper) Binary provides are Ok. $ rpmlint ./perl-Hash-AutoHash* perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US AsObject -> As Object, As-object, Object perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US Inflator -> Inflation, Infiltrator, Inhalator perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US OpenStruct -> Reconstruct, Construct perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US AutoAccessor -> Accessorize perl-Hash-AutoHash.src: W: spelling-error %description -l en_US AsObject -> As Object, As-object, Object perl-Hash-AutoHash.src: W: spelling-error %description -l en_US Inflator -> Inflation, Infiltrator, Inhalator perl-Hash-AutoHash.src: W: spelling-error %description -l en_US OpenStruct -> Reconstruct, Construct perl-Hash-AutoHash.src: W: spelling-error %description -l en_US AutoAccessor -> Accessorize 2 packages and 1 specfiles checked; 0 errors, 8 warnings. Rpmlint is ok Please correct 'FIX' issue. The package looks good. Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Hash-AutoHash Thank you for the review and the repository. I removed the duplicate build requirements. |