Bug 1591122

Summary: git-lfs reports errors during installation
Product: [Fedora] Fedora Reporter: Bojan Smojver <bojan>
Component: git-lfsAssignee: Elliott Sales de Andrade <quantum.analyst>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 28CC: carlwgeorge, customercare, quantum.analyst, rpjday
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: git-lfs-2.5.1-1.fc29 git-lfs-2.4.2-2.fc27 git-lfs-2.4.2-2.fc28 git-lfs-2.4.2-2.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-21 05:26:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Bojan Smojver 2018-06-14 06:36:51 UTC 
Description of problem:

$ sudo dnf install git-lfs
Last metadata expiration check: 2:08:18 ago on Thu 14 Jun 2018 13:48:29 AEST.
Dependencies resolved.
================================================================================
 Package          Arch            Version                Repository        Size
================================================================================
Installing:
 git-lfs          x86_64          2.4.1-1.fc28           updates          2.8 M

Transaction Summary
================================================================================
Install  1 Package

Total download size: 2.8 M
Installed size: 10 M
Is this ok [y/N]: y
Downloading Packages:
git-lfs-2.4.1-1.fc28.x86_64.rpm                 2.8 MB/s | 2.8 MB     00:00    
--------------------------------------------------------------------------------
Total                                           1.6 MB/s | 2.8 MB     00:01     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                        1/1 
  Installing       : git-lfs-2.4.1-1.fc28.x86_64                            1/1 
  Running scriptlet: git-lfs-2.4.1-1.fc28.x86_64                            1/1 
Error: Failed to call git rev-parse --git-dir --show-toplevel: "fatal: not a git repository (or any of the parent directories): .git\n"
Git LFS initialized.
  Verifying        : git-lfs-2.4.1-1.fc28.x86_64                            1/1 

Installed:
  git-lfs.x86_64 2.4.1-1.fc28                                                   

Complete!

Version-Release number of selected component (if applicable):
2.4.1-1.fc28                                                   

How reproducible:
Tried once, got this once.

Steps to Reproduce:
1. Install git-lfs.

Actual results:
Prints errors.

Expected results:
Should probably be silenced or avoided.

Additional info:
Comment 1 Carl George 2018-06-14 12:31:12 UTC 
This was already reported in bug 1580357, however that bug was for two separate issues.  Bodhi closed it for the release that fixed one of the issues, but you are correct that the other one is still a problem.  I'll just leave that one closed and keep this one, rather than opening it back up.

Regardless, this has been reported upstream, and they expect the fix to be part of their 2.5.0 milestone.
Comment 2 Fedora Update System 2018-09-18 07:28:26 UTC 
git-lfs-2.5.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-157b9e6fe6
Comment 3 Fedora Update System 2018-09-21 05:26:38 UTC 
git-lfs-2.5.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
Comment 4 Carl George 2018-10-16 19:04:24 UTC 
*** Bug 1639866 has been marked as a duplicate of this bug. ***
Comment 5 Carl George 2018-10-16 19:28:51 UTC 
Elliot, is there any reason not to merge the 2.5.2 commit back to the F27/F28 branches?  This was reported again in bug 1639866 for F27.
Comment 6 Elliott Sales de Andrade 2018-10-17 09:16:39 UTC 
2.5.0 has some breaking changes, I believe, so it's against the update policy.

I could backport a fix, but we don't really know what fixed it.
Comment 7 Carl George 2018-10-17 18:21:32 UTC 
I'll just modify the scriptlets to redirect their output to /dev/null.
Comment 8 Fedora Update System 2018-10-17 19:00:02 UTC 
git-lfs-2.4.2-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-cc5f270bba
Comment 9 Fedora Update System 2018-10-17 19:00:10 UTC 
git-lfs-2.4.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-21348caec2
Comment 10 Fedora Update System 2018-10-17 19:00:16 UTC 
git-lfs-2.4.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3046c3dfa1
Comment 11 Fedora Update System 2018-10-18 04:50:26 UTC 
git-lfs-2.4.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3046c3dfa1
Comment 12 Fedora Update System 2018-10-18 04:57:11 UTC 
git-lfs-2.4.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-cc5f270bba
Comment 13 Fedora Update System 2018-10-18 05:16:55 UTC 
git-lfs-2.4.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-21348caec2
Comment 14 Fedora Update System 2018-10-26 16:52:06 UTC 
git-lfs-2.4.2-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Comment 15 Fedora Update System 2018-10-26 17:06:32 UTC 
git-lfs-2.4.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
Comment 16 Fedora Update System 2018-11-03 02:59:55 UTC 
git-lfs-2.4.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.