Bug 1591580

Summary:	Remove code duplication in protocol/client
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	protocol	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-23 15:11:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Krutika Dhananjay 2018-06-15 04:26:41 UTC

Description of problem:
client_submit_vec_request() which is used by WRITEV and PUT, and client_submit_request() used by the rest of the fops have almost similar code. However, there are some checks - such as whether setvolume was successful or not, and one more that is send-gid-specific - added more recently that have been missed out in the vectored version of the function. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-06-15 04:45:36 UTC

REVIEW: https://review.gluster.org/20276 (protocol/client: Remove code duplication) posted (#3) for review on master by Krutika Dhananjay

Comment 2 Worker Ant 2018-06-18 03:45:48 UTC

COMMIT: https://review.gluster.org/20276 committed in master by "Krutika Dhananjay" <kdhananj> with a commit message- protocol/client: Remove code duplication

client_submit_vec_request() which is used by WRITEV, and PUT
and client_submit_request() used by the rest of the fops have
almost similar code. However, there have been some more checks
- such as whether setvolume was successful or not, and one more
that is send-gid-specific - that have been missed out in the vectored
version of the function.

This patch fixes this code duplication.

Change-Id: I363a28eeead6219cb1009dc831538153e8bd7d40
fixes: bz#1591580
Signed-off-by: Krutika Dhananjay <kdhananj>

Comment 3 Shyamsundar 2018-10-23 15:11:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/