Bug 159159

Description of problem:
A bug in /sbin/mkkerneldoth causes the wrong architecture to be written in
/boot/kernel.h.

On line 7, a sed expression is supposed to strip the build type (smp, hugemem,
etc.) from 'uname -r' to get the name of the kernel rpm.  However, the
expression is incorrect, resulting in a name that 'rpm -q' can't find. 
Therefore on line 9 the script falls back on 'uname -m' to get the kernel
architecture.  This is incorrect on athlon systems, because 'uname -m' reports
"i686", which is a different kernel build.

This causes problems when building 3rd-party LKM's, because they link to the
wrong kernel symbols (or rather, the symbols for the wrong kernel).


Version-Release number of selected component (if applicable):
I've verified that this bug still exists in initscripts-7.31.22.EL-2, released
just two weeks ago.


How reproducible:
Always.


Steps to Reproduce:
1. Boot with kernel-smp-2.4.*.athlon.rpm
2. Look at /boot/kernel.h

  
Actual results:
/* This file is automatically generated at boot time. */
#ifndef __BOOT_KERNEL_H_
#define __BOOT_KERNEL_H_

/* Kernel type i686-smp */

#ifndef __MODULE_KERNEL_i686
#define __MODULE_KERNEL_i686 1
#endif

#ifndef __BOOT_KERNEL_ENTERPRISE
#define __BOOT_KERNEL_ENTERPRISE 0
#endif

#ifndef __BOOT_KERNEL_BIGMEM
#define __BOOT_KERNEL_BIGMEM 0
#endif

#ifndef __BOOT_KERNEL_HUGEMEM
#define __BOOT_KERNEL_HUGEMEM 0
#endif

#ifndef __BOOT_KERNEL_SMP
#define __BOOT_KERNEL_SMP 1
#endif

#ifndef __BOOT_KERNEL_UP
#define __BOOT_KERNEL_UP 0
#endif

#endif


Expected results:
/* This file is automatically generated at boot time. */
#ifndef __BOOT_KERNEL_H_
#define __BOOT_KERNEL_H_

/* Kernel type athlon-smp */

#ifndef __MODULE_KERNEL_athlon
#define __MODULE_KERNEL_athlon 1
#endif

#ifndef __BOOT_KERNEL_ENTERPRISE
#define __BOOT_KERNEL_ENTERPRISE 0
#endif

#ifndef __BOOT_KERNEL_BIGMEM
#define __BOOT_KERNEL_BIGMEM 0
#endif

#ifndef __BOOT_KERNEL_HUGEMEM
#define __BOOT_KERNEL_HUGEMEM 0
#endif

#ifndef __BOOT_KERNEL_SMP
#define __BOOT_KERNEL_SMP 1
#endif

#ifndef __BOOT_KERNEL_UP
#define __BOOT_KERNEL_UP 0
#endif

#endif


Additional info:
See bug #159098 for a description of sed's behavior.  (It's not a sed bug; it's
a mkkerneldoth bug.)

The bug can be fixed by changing the expression delimiter from '|' to (almost)
any other character, such as '_' (which would be consistent with lines 5 and 11).

--- mkkerneldoth.orig   2003-08-08 12:09:41.000000000 -0700
+++ /sbin/mkkerneldoth  2005-05-29 12:22:49.000000000 -0700
@@ -4,7 +4,7 @@
 #
 
 KERNEL_TYPE=`uname -r | sed
's_^.*\(smp\|enterprise\|bigmem\|hugemem\)$_-\1_;t;s_.*__;'`
-KERNEL_RELEASE=`uname -r | sed 's|smp\|enterprise\|bigmem\|hugemem||g'`
+KERNEL_RELEASE=`uname -r | sed 's_smp\|enterprise\|bigmem\|hugemem__g'`
 
 rpm -q kernel$KERNEL_TYPE-$KERNEL_RELEASE >/dev/null 2>&1 && KERNEL_ARCH=`rpm
-q --qf '%{ARCH}' kernel$KERNEL_TYPE-$KERNEL_RELEASE 2>/dev/null` ||
KERNEL_ARCH=`uname -m`