Bug 1592114

Summary: StreamingAPI- Download disk image & try to resume via SDK - operation should fail but succeeds
Product: [oVirt] ovirt-engine Reporter: Avihai <aefrat>
Component: BLL.StorageAssignee: Idan Shaby <ishaby>
Status: CLOSED CURRENTRELEASE QA Contact: Natalie Gavrielov <ngavrilo>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.2.4.1CC: bugs, ebenahar, tnisan
Target Milestone: ovirt-4.2.5Keywords: Automation
Target Release: 4.2.5Flags: rule-engine: ovirt-4.2+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.2.5 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-31 15:29:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log SDK script none

Description Avihai 2018-06-17 10:45:00 UTC 
Created attachment 1452357 [details]
engine log SDK script

Description of problem:
Download disk image & try to resume via SDK(see script attached) - operation should fail but succeeds.

I saw this issue while testing download pause/resume flows on bug 1583698.
After discussion with Idan, it was decided to open this bug.

There is no apparent impact other than :
- The expected HTTP error does not appear.
- Matching Engine error & Event not appearing 

Engine issues an EVENT of its success to resume:
6500202fcc0d] EVENT_ID: TRANSFER_IMAGE_RESUMED_BY_USER(1,074), Image transfer was resumed by user (admin@internal-authz) 

More detailed Engine log:
- Resume section
2018-06-17 11:42:16,175+03 INFO  [org.ovirt.engine.core.bll.storage.disk.image.ImageTransferUpdater] (default task-30) [559b92c0-6b94-48df-8b94-98512a4475ee] Updating image transfer fe260258-74d5-434e-8068-9607b1653e5a (image 1ebcf398-3023-4c9e-ab50-c24b09c19dcb) phase to Resuming
2018-06-17 11:42:16,228+03 INFO  [org.ovirt.engine.core.bll.storage.disk.image.TransferImageStatusCommand] (default task-29) [f297b541-1822-4077-a65b-eab640947970] Running command: TransferImageStatusCommand internal: false. Entities affected :  ID: aaa00000-0000-0000-0000-123456789aaa Type: SystemAction group CREATE_DISK with role type USER
2018-06-17 11:42:16,873+03 INFO  [org.ovirt.engine.core.bll.storage.disk.image.TransferDiskImageCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-88) [bf2ac043-d1b3-4b73-9004-6500202fcc0d] Resuming transfer for Download disk 'download_disk1' (disk id: '1ebcf398-3023-4c9e-ab50-c24b09c19dcb', image id: 'bc4c4c6c-f73a-453c-9298-f0657b8a672f')
2018-06-17 11:42:16,901+03 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engineScheduled-Thread-88) [bf2ac043-d1b3-4b73-9004-6500202fcc0d] EVENT_ID: TRANSFER_IMAGE_RESUMED_BY_USER(1,074), Image transfer was resumed by user (admin@internal-authz).

Version-Release number of selected component (if applicable):
4.2.4.1-0.1

How reproducible:
100%

Steps to Reproduce:
Via SDK script ( see it attached):
1. Start download to a disk image.
2. When reaching 50% download try to pause the download - it fails as expected.
3. Then try to resume the transfer.

Actual results:
The resume operation is successful, an event of its success it issued in the engine log.

Expected results:
The resume operation should fail with a meaningful error in the engine log and an event of its failure should be issued in the engine log.

Additional info:
Comment 1 Natalie Gavrielov 2018-07-12 13:55:02 UTC 
Verified, used build: 4.2.5.2_SNAPSHOT-76.g2d45cde.0.scratch.master.el7ev (and the script attached)
Comment 2 Sandro Bonazzola 2018-07-31 15:29:59 UTC 
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.