Bug 1592571
| Summary: | Service Dialog Editor localization in French Incomplete | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | David Luong <dluong> | ||||
| Component: | UI - OPS | Assignee: | Shveta <sshveta> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.9.0 | CC: | cpelland, dclarizi, dmetzger, hkataria, jprause, lavenel, mfeifer, mpovolny, mzazrivec, obarenbo, rblanco, simaishi, smallamp | ||||
| Target Milestone: | GA | Keywords: | ZStream | ||||
| Target Release: | 5.9.5 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.9.5.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-11-05 13:58:27 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1578510 | ||||||
| Attachments: |
|
||||||
|
Description
David Luong
2018-06-18 21:46:33 UTC
This part of our UI was re-written from ruby to angular recently. I'm re-assigning this bz over to chhale, who's the author (iirc) and knows the code much better than me. Thanks. The only PR that's currently still waiting for review & merge is https://github.com/ManageIQ/manageiq/pull/17740 Otherwise I need to have the translations done & merged before I can move this one to POST. New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili: https://github.com/ManageIQ/manageiq-ui-classic/commit/a9e043da20d0e00ba313063bfb30f5e3ce63d653 commit a9e043da20d0e00ba313063bfb30f5e3ce63d653 Author: Martin Hradil <himdel> AuthorDate: Fri Jul 20 08:40:17 2018 -0400 Commit: Martin Hradil <himdel> CommitDate: Fri Jul 20 08:40:17 2018 -0400 Merge pull request #4323 from mzazrivec/add_angular_gettext_and_make_translation_directive_working Add angular gettext and make translation directive working (cherry picked from commit b108b45fc773ed02c0a8dc76cf866ae56e9032d4) https://bugzilla.redhat.com/show_bug.cgi?id=1592571 app/assets/javascripts/application.js | 2 + app/assets/javascripts/gettextCatalog.js | 12 + app/assets/javascripts/miq_angular_application.js | 1 + package.json | 1 + 4 files changed, 16 insertions(+) New commit detected on ManageIQ/manageiq/gaprindashvili: https://github.com/ManageIQ/manageiq/commit/23aed0ac017c9a20bda94c98818d9e8880de7845 commit 23aed0ac017c9a20bda94c98818d9e8880de7845 Author: Milan Zazrivec <mzazrivec> AuthorDate: Wed Jul 18 10:28:00 2018 -0400 Commit: Milan Zazrivec <mzazrivec> CommitDate: Wed Jul 18 10:28:00 2018 -0400 locale:po_to_json: add support for including catalogs from js plugins (cherry picked from commit 60bac8255f8fbd95fde2c44356b9b70771b34413) https://bugzilla.redhat.com/show_bug.cgi?id=1592571 lib/tasks/locale.rake | 72 +- 1 file changed, 51 insertions(+), 21 deletions(-) (In reply to John Prause from comment #27) > Milan: It appears the PRs are all merged. If there's nothing else needed, > can you move this to POST. The BZ stays in ON_DEV. (In reply to John Prause from comment #27) > Milan: It appears the PRs are all merged. If there's nothing else needed, > can you move this to POST. Please, read comment #24, it may help you. Thanks Milan, your response in comment 30 was exactly what I was looking for. Change to 5.9.5 per Bascar https://github.com/ManageIQ/ui-components/pull/338 https://github.com/ManageIQ/manageiq-ui-classic/pull/4506 Created attachment 1489517 [details]
Service dialog editor
Verified in 5.9.5.0.20180927190514_e161d8f
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3466 |