Bug 1592782

Summary:	Review Request: perl-Syntax-Keyword-Gather - Implements the Perl 6 'gather/take' control structure in Perl 5
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-28 14:08:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1593893

Description Emmanuel Seyman 2018-06-19 10:00:19 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Syntax-Keyword-Gather/perl-Syntax-Keyword-Gather.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Syntax-Keyword-Gather/perl-Syntax-Keyword-Gather-1.003002-1.fc28.src.rpm
Description:
Perl 6 provides a new control structure -- gather -- that allows lists to
be constructed procedurally, without the need for a temporary variable.
Within the block/closure controlled by a gather any call to take pushes
that call's argument list to an implicitly created array. take returns the
number of elements it took. This module implements that control structure.

Rpmlint Output:
perl-Syntax-Keyword-Gather.src: W: spelling-error %description -l en_US procedurally -> procedural
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: eseyman

Comment 1 Robert-André Mauchin 🐧 2018-06-19 12:56:45 UTC

URL and Source addresses are Ok.
Source archive (SHA-256: 8bd62205e1645c0915d28340801f245e4551b4f580f5e2735a39fc426c066207) is original. Ok.
Summary verified from lib/Syntax/Keyword/Gather.pm. Ok.
Description verified from lib/Syntax/Keyword/Gather.pm. Ok.
License verified from lib/Syntax/Keyword/Gather.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Syntax-Keyword-Gather.spec review-perl-Syntax-Keyword-Gather/results/perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm review-perl-Syntax-Keyword-Gather/results/perl-Syntax-Keyword-Gather-1.003002-1.fc29.src.rpm 
perl-Syntax-Keyword-Gather.noarch: W: spelling-error %description -l en_US procedurally -> procedural
perl-Syntax-Keyword-Gather.src: W: spelling-error %description -l en_US procedurally -> procedural
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

$ rpm -q -lv -p perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm
drwxr-xr-x    2 root    root                        0 juin 19 14:44 /usr/share/doc/perl-Syntax-Keyword-Gather
-rw-r--r--    1 root    root                     1172 févr. 16 15:42 /usr/share/doc/perl-Syntax-Keyword-Gather/Changes
-rw-r--r--    1 root    root                     5304 févr. 16 15:42 /usr/share/doc/perl-Syntax-Keyword-Gather/README
drwxr-xr-x    2 root    root                        0 juin 19 14:44 /usr/share/licenses/perl-Syntax-Keyword-Gather
-rw-r--r--    1 root    root                    18391 févr. 16 15:42 /usr/share/licenses/perl-Syntax-Keyword-Gather/LICENSE
-rw-r--r--    1 root    root                     3414 juin 19 14:44 /usr/share/man/man3/Syntax::Keyword::Gather.3pm.gz
drwxr-xr-x    2 root    root                        0 juin 19 14:44 /usr/share/perl5/vendor_perl/Syntax
drwxr-xr-x    2 root    root                        0 juin 19 14:44 /usr/share/perl5/vendor_perl/Syntax/Keyword
-rw-r--r--    1 root    root                     6997 févr. 16 15:42 /usr/share/perl5/vendor_perl/Syntax/Keyword/Gather.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Carp)
      1 perl(overload)
      1 perl(strict)
      1 perl(Sub::Exporter::Progressive)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm
perl(Syntax::Keyword::Gather) = 1.003002
perl(Syntax::Keyword::Gather::MagicArrayRef) = 1.003002
perl-Syntax-Keyword-Gather = 1.003002-1.fc29
Binary provides are Ok.

Package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=27729985)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

Comment 2 Emmanuel Seyman 2018-06-19 21:43:49 UTC

Yay! Thanks for the review, Robert-André. I've gone ahead and requested the repo.

Comment 3 Gwyn Ciesla 2018-06-19 21:45:16 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-Gather

Comment 4 Fedora Update System 2018-06-20 05:45:38 UTC

perl-Syntax-Keyword-Gather-1.003002-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f32d92deee

Comment 5 Fedora Update System 2018-06-20 16:08:53 UTC

perl-Syntax-Keyword-Gather-1.003002-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f32d92deee

Comment 6 Fedora Update System 2018-06-28 14:08:25 UTC

perl-Syntax-Keyword-Gather-1.003002-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.