Bug 1593263

Summary: rsync warning about symlink (which looks unimportant) leads to rsnapshot error
Product: [Fedora] Fedora Reporter: ell1e <el>
Component: rsnapshotAssignee: Steven Roberts <strobert>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 28CC: james.hogarth, strobert
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-25 02:07:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description ell1e 2018-06-20 12:12:05 UTC
Description of problem:

I am running rsnapshot in some script but it fails with an error due to something which looks kind of unimportant (I'm not sure what exactly it tried to do):

ERROR: /usr/bin/rsync returned 255 while processing root@company:/srv/
WARNING: Rolling back "root_company_srv/"
rm -rf /home/jonas/backup-XXX-de/.sync/root_company_srv/ 
native_cp_al("/home/jonas/backup-XXX-de/snapshot.0/root_company_srv", \
    "/home/jonas/backup-XXX-de/.sync/root_company_srv") 
WARNING: Could not lchown() symlink "/home/jonas/backup-XXX-de/.sync/root_company_srv/srv/proxy/volumes/nginx/certs/XXX.XXX.de.dhparam.pem"
WARNING: Could not lchown() symlink "/home/jonas/backup-XXX-de/.sync/root_company_srv/srv/proxy/volumes/nginx/certs/relaunch.XXX.de.dhparam.pem"
WARNING: Could not lchown() symlink "/home/jonas/backup-XXX-de/.sync/root_company_srv/srv/proxy/volumes/nginx/certs/www.XXX.de.dhparam.pem"

(XXX are names I removed from the log)

This is really problematic because I run this from another script automatically, and if it fails for this which rsync itself clearly treats as just a warning, I can't differentiate it from actual errors to complete the backup properly.

Version-Release number of selected component (if applicable):
rsnapshot-1.4.2-5.fc28

How reproducible:
100% for that specific rsnapshot target, works fine for others

Steps to Reproduce:
1. Configure backup
2. ???
3. Run rsnapshot backup

Actual results:
rsnapshot stops with error

Expected results:
rsnapshot stops with warning or completes, with the exit code not indicating a regular error

Additional info:

Comment 1 ell1e 2018-06-25 02:07:14 UTC
oops, I just read the error output wrong. the warning was actually during the rollback, not the actual cause - the cause was just an incorrect ssh config, haha. so this is entirely my fault