Bug 1593451
Summary: | growpart fails when partition start sector is the same as partition size | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | John Pittman <jpittman> | ||||
Component: | cloud-utils-growpart | Assignee: | Lars Kellogg-Stedman <lars> | ||||
Status: | CLOSED ERRATA | QA Contact: | Yuxin Sun <yuxisun> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 7.5 | CC: | eterrell, jpittman, lars, mrezanin, ndordet, nweddle, ribarry, tcleveng, vhutsky, wshi, xiachen, yacao, yujiang, yuxisun | ||||
Target Milestone: | rc | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 0.29-3 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | |||||||
: | 1666854 (view as bug list) | Environment: | |||||
Last Closed: | 2019-08-06 13:18:47 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1666854 | ||||||
Attachments: |
|
We'll need to get the patch accepted upstream first. I've opened an upstream bug and I'll submit the patch against it. I've submitted a merge request upstream: https://code.launchpad.net/~larsks/cloud-utils/cloud-utils/+merge/360197 That's a smaller patch than what was proposed here, but it seems to work in my tests. I have corrected the root cause description in https://access.redhat.com/solutions/3494521. I replaced the earlier merge request with https://code.launchpad.net/~larsks/cloud-utils/bug-1807171/+merge/360264, which has since merged upstream: https://bazaar.launchpad.net/~cloud-utils-dev/cloud-utils/trunk/revision/339 I'll backport this into our cloud-utils package. Lars, yes that fixed the issue. Thanks. [root@localhost ~]# rpm -ivh cloud-utils-growpart-0.29-3.el7.noarch.rpm Preparing... ################################# [100%] Updating / installing... 1:cloud-utils-growpart-0.29-3.el7 ################################# [100%] [root@localhost ~]# parted /dev/vda u s p Model: Virtio Block Device (virtblk) Disk /dev/vda: 44040192s Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 2048s 2099199s 2097152s primary xfs boot 2 2099200s 20971519s 18872320s primary lvm 3 20971520s 41943039s 20971520s primary [root@localhost ~]# growpart /dev/vda 3 CHANGED: partition=3 start=20971520 old: size=20971520 end=41943040 new: size=23068639,end=44040159 [root@localhost ~]# parted /dev/vda u s p Model: Virtio Block Device (virtblk) Disk /dev/vda: 44040192s Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 2048s 2099199s 2097152s primary xfs boot 2 2099200s 20971519s 18872320s primary lvm 3 20971520s 44040158s 23068639s primary Note that since last week, upstream has moved to git, so the fix can now be found at: https://git.launchpad.net/cloud-utils/commit/?id=07c5a5a85e8ea2c1827a0c4948da3b6ca160414f Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2340 |
Created attachment 1453297 [details] patchfile Description of problem: The growpart command will fail if the partition start sector is the same as partition size. Version-Release number of selected component (if applicable): cloud-utils-growpart-0.29-2.el7 Steps to Reproduce: - Make a partition that has same Start and Size: [root@localhost ~]# parted /dev/sda u s p Model: ATA QEMU HARDDISK (scsi) Disk /dev/sda: 41943040s Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 2048s 1953791s 1951744s primary ext4 boot 2 1953792s 19531250s 17577459s primary lvm 3 19531251s 39062501s 19531251s primary - Attempt growpart: [root@localhost ~]# growpart /dev/sda 3 failed [pt_update:1] pt_update /dev/sda 3 partx: /dev/sda: updating partition #3 failed: Invalid argument partx: /dev/sda: error updating partition 3 partition: none, disk: /dev/sda, lower: 3, upper: 3 /dev/sda: partition table type 'dos' detected /dev/sda: partition #3 resized FAILED: pt_resize failed ***** WARNING: Resize failed, attempting to revert ****** Re-reading the partition table ... BLKRRPART: Device or resource busy sfdisk: The command to re-read the partition table failed. Run partprobe(8), kpartx(8) or reboot your system now, before using mkfs ***** Appears to have gone OK **** Actual results: growpart fails Expected results: growpart succeeds Additional info: Patch file attached