Bug 1593836

Summary: Cannot create VG on Fedora 28
Product: [oVirt] vdsm Reporter: Nir Soffer <nsoffer>
Component: CoreAssignee: Eyal Shenitzky <eshenitz>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.30.0CC: bugs, mcsontos, nsoffer, tnisan
Target Milestone: ovirt-4.2.5Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-31 15:30:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1575762    
Bug Blocks: 1460625    

Description Nir Soffer 2018-06-21 16:11:11 UTC
Description of problem:

Creating a new storage domain on block storage fails now with:

2018-06-21 18:26:48,389+0300 DEBUG (jsonrpc/6) [storage.Misc.excCmd] /usr/bin/taskset --cpu-list 0-7 /usr/bin/sudo -n /usr/sbin/lvm pvcreate --config ' devices { preferred_names = ["^/dev/mapper/"] ignore_suspended_devices=1 write_cache_state=0 disable_after_error_count=3 filter = [ '\''a|/dev/mapper/3600140507fc51a354e3423091d01e56d|/dev/mapper/360014050b0743fa819f4d83bfa3f910
7|/dev/mapper/3600140515dd257e644140d4bd09f584b|/dev/mapper/360014052557433e46b14abd91cfaae1d|/dev/mapper/360014052761af2654a94a70a60a7ee3f|/dev/mapper/360014052de8e2b8007944a1a93a82c40|/dev/mapper/360014052e489b6f5ed34881ac5ed27fd|/dev/mapper/36001405376e34ea70384de7a34a2854d|/dev/mapper/3600140547486d12d71b460ba82030e21|/dev/mapper/36001405560f9d98242841cea375c479e|/dev/mapper/3600140558a6c264f95347b69f4498ec5|/dev/mapper/360014055fc8e87631db462caf5970d32|/dev/mapper/360014056d9f638f8c3547c29e220ea48|/dev/mapper/360014057fa61996be7d415ab973938d5|/dev/mapper/36001405805d8139e5d74ae09fe0b89af|/dev/mapper/36001405847ec541476043d4ac9260d41|/dev/mapper/360014059f183cadcc594539a24a523c0|/dev/mapper/36001405b73582e5c6b94307ad4d0f3f8|/dev/mapper/36001405bfc49549313946daa720cb1ba|/dev/mapper/36001405c7e898bc42974f1bb57ed686a|'\'', '\''r|.*|'\'' ] }  global {  locking_type=1  prioritise_write_locks=1  wait_for_locks=1  use_lvmetad=0 }  backup {
  retain_min = 50  retain_days = 0 } ' -y -ff --metadatasize 128m --metadatacopies 2 --metadataignore y /dev/mapper/360014052761af2654a94a70a60a7ee3f /dev/mapper/36001405c7e898bc42974f1bb57ed686a (cwd None) (commands:66)

2018-06-21 18:26:48,838+0300 DEBUG (jsonrpc/6) [storage.Misc.excCmd] FAILED: <err> = '  /dev/cdrom: open failed: No medium found\n  WARNING: PV OAqHJb-Urgl-EC2l-EodV-pdMF-goEJ-K0VvEv on /dev/mapper/360014052761af2654a94a70a60a7ee3f was already found on /dev/sda.\n  WARNING: PV 8EIZOh-wjZa-oUGk-BfgH-XBfW-c5eD-hpgG5w on /dev/sdt was already found on /dev/mapper/36001405c7e898bc42974f1bb57ed686a.\n  WARNING: PV OAqHJb-Urgl-EC2l-EodV-pdMF-goEJ-K0VvEv prefers device /dev/mapper/360014052761af2654a94a70a60a7ee3f because device is in dm subsystem.\n  WARNING: PV 8EIZOh-wjZa-oUGk-BfgH-XBfW-c5eD-hpgG5w prefers device /dev/mapper/36001405c7e898bc42974f1bb57ed686a because device is in dm subsystem.\n  Cannot use device /dev/mapper/36001405c7e898bc42974f1bb57ed6
86a with duplicates.\n  Cannot use device /dev/mapper/360014052761af2654a94a70a60a7ee3f with duplicates.\n'; <rc> = 5 (commands:87)

Version-Release number of selected component (if applicable):
Anhy

How reproducible:
100%

Steps to Reproduce:
1. Create new storage domain on block storage

Actual results:
Fails

Expected results:
Succeeds

Additional info:

Vdsm uses lvm filter that allow reading only /dev/mapper/xxxyyy, but lvm
complain that the pv exists on both /dev/mapper/xxxyyy and the underlying
path (/dev/sda).

According to lvm developers, this is caused by bug 1575762 which in turn
is caused by GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86231.

Workaround:

In bug 1575762 it was suggested to enable this config
option:
allow_changes_with_duplicate_pvs=1

I added it to vdsm lvm config, but it still fail with the same error.

Comment 1 Nir Soffer 2018-06-24 17:17:45 UTC
Tal, we don't support adding Fedora 28 host in engine 4.2, so I think this should
move to 4.3.

In the meantime, David fixed this on lvm side:
https://www.redhat.com/archives/lvm-devel/2018-June/msg00180.html

So I guess next lvm build on Fedora 28 should fix this issue.

Comment 2 Marian Csontos 2018-06-25 08:25:57 UTC
Could you try:

1. use global_filter, just in case...

2. use lvm2-2,02.177-5.fc28 (https://koji.fedoraproject.org/koji/buildinfo?buildID=1096618)

Comment 3 Tal Nisan 2018-06-25 09:34:35 UTC
(In reply to Nir Soffer from comment #1)
> Tal, we don't support adding Fedora 28 host in engine 4.2, so I think this
> should
> move to 4.3.
> 
> In the meantime, David fixed this on lvm side:
> https://www.redhat.com/archives/lvm-devel/2018-June/msg00180.html
> 
> So I guess next lvm build on Fedora 28 should fix this issue.

We don't support for now but I figured we might in future 4.2.z so we can require the fixed version of lvm anyway, sounds OK?

Comment 4 Nir Soffer 2018-06-26 23:11:18 UTC
(In reply to Tal Nisan from comment #3)
> We don't support for now but I figured we might in future 4.2.z so we can
> require the fixed version of lvm anyway, sounds OK?

Good idea. I tested the fixed lvm package (lvm2-2.02.177-5.fc28) and it works fine.
I can create block storage domains now.

We will require the package once it is available (currently only updates-testing).

Comment 5 Elad 2018-07-12 13:42:46 UTC
Moving to VERIFIED based on comment #4

Comment 6 Sandro Bonazzola 2018-07-31 15:30:33 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.