Bug 1594083 (CVE-2018-13348)

Summary: CVE-2018-13348 mercurial: Improper length check in mpatch.c
Product: [Other] Security Response Reporter: Sam Fowler <sfowler>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: gmainwar, jlaska, katzj, mads, ndbecker2, pcahyna, skisela
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: mercurial 4.6.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-27 04:51:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1594084, 1594085    
Bug Blocks: 1594086    

Description Sam Fowler 2018-06-22 04:35:41 UTC
Mercurial before version 4.6.1 does not properly check the length of binary patch data.


Upstream Changelog:

https://www.mercurial-scm.org/wiki/WhatsNew#Mercurial_4.6.1_.282018-06-06.29


Upstream Patches:

https://www.mercurial-scm.org/repo/hg/rev/90a274965de7

Comment 1 Sam Fowler 2018-06-22 04:36:08 UTC
Created mercurial tracking bugs for this issue:

Affects: fedora-all [bug 1594084]

Comment 3 Doran Moppert 2018-07-27 04:47:36 UTC
In earlier versions of mercurial (inc 2.6.2), the pointer was maintained at the end of the region that would be read, so overflow was not possible.