Bug 1594378
| Summary: | Review Request: ignition-dracut - dracut modules for ignition | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dusty Mabe <dustymabe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-06-25 19:33:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dusty Mabe
2018-06-22 19:00:58 UTC
Taking this review. Simple question, why are you regenerating the entire spec file every time for ignition with gofed? For snapd, I just use gofed to update the BuildRequires and Provides list. Generally, the rest of the spec doesn't change much. (In reply to Neal Gompa from comment #2) > Simple question, why are you regenerating the entire spec file every time > for ignition with gofed? For snapd, I just use gofed to update the > BuildRequires and Provides list. Generally, the rest of the spec doesn't > change much. yeah. i'm a bit of a noob with go packaging. I tend to regenerate the spec into a new file then vimdiff the old .orig and .spec file to see what I changed last time. Then add those changes to the new spec I created and check it all in (new .orig and new .spec). is there another command you use other than `gofed repo2spec` ? (In reply to Dusty Mabe from comment #3) > (In reply to Neal Gompa from comment #2) > > Simple question, why are you regenerating the entire spec file every time > > for ignition with gofed? For snapd, I just use gofed to update the > > BuildRequires and Provides list. Generally, the rest of the spec doesn't > > change much. > > yeah. i'm a bit of a noob with go packaging. I tend to regenerate the spec > into a new file then vimdiff the old .orig and .spec file to see what I > changed last time. Then add those changes to the new spec I created and > check it all in (new .orig and new .spec). is there another command you use > other than `gofed repo2spec` ? I use repo2spec too, only because the aspect I want hasn't been broken out into a subcommand yet. But I just copy the Provides: lines and overwrite them in my spec file every time. It's not terribly difficult and because the rest of the spec rarely changes, it's pretty easy. In your case, you don't even really have to do BR checking, since you're using bundled dependencies (snapd is fully unbundled for Fedora). (In reply to Neal Gompa from comment #4) > > I use repo2spec too, only because the aspect I want hasn't been broken out > into a subcommand yet. But I just copy the Provides: lines and overwrite > them in my spec file every time. Yeah I guess that's essentially what I'm doing too, but with an extra layer of "vimdiff" in there to make sure nothing else changed. Probably not needed. It was requested that I add ignition-dracut as a subpackage of ignition instead of a separate package. See https://bugzilla.redhat.com/show_bug.cgi?id=1576879#c16 *** This bug has been marked as a duplicate of bug 1576879 *** |