Bug 1594572
| Summary: | Kernel 4.17.2 does not recognise Asus K501UB laptop keyboard/trackpad | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Roy <nouveau> | ||||||||
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | urgent | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 28 | CC: | airlied, bskeggs, ewk, hdegoede, ichavero, itamar, jarodwilson, jcline, jglisse, john.j5live, jonathan, josef, kernel-maint, labbott, linville, mchehab, mjg59, steved | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2018-06-27 15:43:59 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Roy
2018-06-24 15:00:00 UTC
Created attachment 1454143 [details]
Dmesg of machine booting with kernel 4.17.2-200
Created attachment 1454157 [details]
Correct dmesg of machine booting with kernel 4.16.16-300
*** Bug 1594571 has been marked as a duplicate of this bug. *** To follow up on a question asked on freenode/#fedora-devel: Removing the blacklist entry for asus-nb-wmi does not change the situation, the keyboard still is not functioning at all on the released 4.17.2 kernel. The problem is that when it's trying to allocate an IDR and there isn't one available. Nothing in that code has changed recently as far as I see. Could you see if you can narrow down where the regression got introduced? All the pre-release 4.17 kernels we've built can be found in Koji[0]. I'd first see if it's in rc1 (kernel-4.17.0-0.rc1.git0.1.fc29). If it is, see which of the rc0 kernels it happened in. Otherwise, see which rc build introduced the problem. [0] https://koji.fedoraproject.org/koji/search?match=glob&type=build&terms=kernel-4.17* Created attachment 1454423 [details]
ACPI dump Asus K501UB
Okay, I've done a poor-mans bisect using koji kernels, and found the bug was introduced between kernel-4.17.0-0.rc0.git1.1.fc29 and kernel-4.17.0-0.rc0.git4.1.fc29. I have attached an ACPI dump as well, as I'm 99% certain that the vast increase in ACPI errors are related to my problems. We had a little back-and-forth on IRC where I dare to conclude the following: - Allocating an IDR fails if it's called with a "start" integer smaller than 0. For I2C devices this is set to adap->nr, unless adap->nr is -1, in which case it's assigned to __i2c_first_dynamic_bus_num. - __i2c_first_dynamic_bus_num does not have a default value and is only initialised in i2c_register_board_info(). If due to ACPI problems this function is never called, it could default to anything including a negative number, causing the allocation to fail. Does it make sense to assign a default value to __i2c_first_dynamic_bus_num regardless of whether ACPI needs fixing? - Semi-related: I've also lost a lot of suspend modes. 4.16 reports "ACPI: (supports S0 S3 S4 S5)", 4.17 reports ACPI: (supports S0). There many warnings in the logs leading up to that. This all really needs to be discussed upstream with the maintainers of the code since Fedora closely tracks that. I'd start with the maintainers of the intel-lpss framework, Jarkko Nikula <jarkko.nikula.com>, Andy Shevchenko <andriy.shevchenko.com> plus the ACPI maintainer Rafael J. Wysocki <rafael.j.wysocki> along with the usual mailing lists. If you have the ability, doing a kernel bisect to identify the specific commit that broke would be very helpful as well. Symptoms are gone with the just-released-upstream 4.17.3 kernel. |