Bug 1594857

Summary:	Make smoke runs detect test cases added to patch
Product:	[Community] GlusterFS	Reporter:	Amar Tumballi <atumball>
Component:	project-infrastructure	Assignee:	Deepshikha khandelwal <dkhandel>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	amukherj, bugs, dkhandel, gluster-infra, jeff, srangana
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Process-Automation
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-12 10:48:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amar Tumballi 2018-06-25 14:38:54 UTC

# Description of problem:

Today, there is no validation of test cases 'per patch'. Specially for features being added to codebase.

I would propose we need .t file being changed in patch, or else, a commit message should have a section called "Testind done:" (can be added as a check in ./rfc.sh) which would vote +1, or else, it would vote -1.


# Additional info:

Technically speaking, if the patch has only .testignore files, then this test may not vote, so smoke will go ahead with all other tests.

Comment 1 Amar Tumballi 2018-06-25 14:39:54 UTC

We need public announcement of this before making this change in process.

Comment 2 Nigel Babu 2018-10-05 08:47:48 UTC

Getting smoke to fail if there's no .t file is not hard. But there are a lot of patches where we're fixing Coverity or static analysis failures where this will be more nuisance than useful. Should this be yet another flag like Spec Added?

Comment 4 Worker Ant 2020-03-12 10:48:59 UTC

This bug is moved to https://github.com/gluster/project-infrastructure/issues/3, and will be tracked there from now on. Visit GitHub issues URL for further details