Bug 1595052

Summary: Brick dashboard / Disk Load section - Throughput and Latency panel units are confusing
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Anand Paladugu <apaladug>
Component: web-admin-tendrl-monitoring-integrationAssignee: Ankush Behl <anbehl>
Status: CLOSED ERRATA QA Contact: Filip Balák <fbalak>
Severity: high Docs Contact:
Priority: unspecified    
Version: rhgs-3.4CC: mbukatov, nthomas, rhs-bugs, sankarshan
Target Milestone: ---   
Target Release: RHGS 3.4.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: tendrl-monitoring-integration-1.6.3-7.el7rhgs Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-04 07:08:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1503137    
Attachments:
Description Flags
screenshot 1: Disk Dashboard with Disk Load section
none
Brick - Disk Throughput none

Description Anand Paladugu 2018-06-26 02:20:59 UTC
Description of problem: Brick dashboard / Disk Load section - Throughput and Latency panel units are confusing.

Throughput Units are in "Mil". Is that Million IOPS ?  I am assuming that we want represent throughput in MBPS/GBPS.

Latency units are in "K".  Is that K milli seconds ?

Please update the panel information and graphs with correct units.


Version-Release number of selected component (if applicable): 3.4 (Sandbox Environment)


How reproducible: Always


Steps to Reproduce:
1. View the panels above and check the units.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Martin Bukatovic 2018-06-27 18:13:41 UTC
Assuming this has been reported based on sandbox-usm1 instance, the             
full package version list follows:                                              
                                                                                
```                                                                             
[root@sandbox-usm1-server ~]# rpm -qa | grep tendrl | sort                      
tendrl-ansible-1.6.3-5.el7rhgs.noarch                                           
tendrl-api-1.6.3-3.el7rhgs.noarch                                               
tendrl-api-httpd-1.6.3-3.el7rhgs.noarch                                         
tendrl-commons-1.6.3-7.el7rhgs.noarch                                           
tendrl-grafana-plugins-1.6.3-5.el7rhgs.noarch                                   
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch                                   
tendrl-monitoring-integration-1.6.3-5.el7rhgs.noarch                            
tendrl-node-agent-1.6.3-7.el7rhgs.noarch                                        
tendrl-notifier-1.6.3-4.el7rhgs.noarch                                          
tendrl-selinux-1.5.4-2.el7rhgs.noarch                                           
tendrl-ui-1.6.3-4.el7rhgs.noarch                                                
```

Comment 3 Martin Bukatovic 2018-06-27 18:16:58 UTC
Created attachment 1455108 [details]
screenshot 1: Disk Dashboard with Disk Load section

Comment 4 Ankush Behl 2018-07-02 07:20:25 UTC
(In reply to Anand Paladugu from comment #0)
> Description of problem: Brick dashboard / Disk Load section - Throughput and
> Latency panel units are confusing.
> 
> Throughput Units are in "Mil". Is that Million IOPS ?  I am assuming that we
> want represent throughput in MBPS/GBPS.

Yes, "Mil" is the Million IOPS. Will change it to MBPS/GBPS 

> Latency units are in "K".  Is that K milli seconds ?

K is basically the default units that gets added to the graphs in grafana. So it's correct that we are showing K ms. 

Should we show it in KBPS/MBPS?

Comment 5 Martin Bukatovic 2018-07-03 12:15:01 UTC
On the one hand Ankush states that the values here is Million IOPS, but on the
other hand he says that we will change it to MBPS/GBPS.

I can't provide qe ack as it's not clear to me if the value reported should be
IOPS (number of IO operations per second) or throughput (bits per second) and
if the fix is about tweaking unit only, of if the fix includes tweaking the
way data are collected and reported.

Comment 6 Ankush Behl 2018-07-03 12:45:01 UTC
Created attachment 1456232 [details]
Brick - Disk Throughput

Comment 7 Ankush Behl 2018-07-03 12:46:10 UTC
@martin - Sorry for adding the confusion here, The throughput panel showing read(bps) and write(bps) which is throughput only. 

We need to tweak the units only from(K, Mil) to MBPS/GBPS.

Please refer to the attachment(Brick - Disk Throughput) for more clarity on how this is going to look like.

Comment 8 Martin Bukatovic 2018-07-04 16:34:28 UTC
Ok, thanks for the clarification. So QE team assumes that:

descriptions (labels) of charts (eg. Throughput, Latency) in "Disk Load"
section of Brick Dashboard are correct (described the values reported
there properly).

And that we need to tweak units of measurement to fit the values, so that:

 * Throughput chart uses kilobit per second as a unit, or
   scaled variant such as megabit per second, based on the order of
   magnitude of the values shown there.

 * Latency chart uses second as a unit, or scaled variant such as
   ms (milisecond) or us (microsecond) based on the order of magnitude
   of the values shown there.

Comment 13 Filip Balák 2018-08-14 11:37:20 UTC
Based on comment 8 I VERIFY this BZ:

 * Throughput chart uses bps as a unit or its variants (kbps, Mbps).
 * Latency chart uses ms as a unit.

Tested with:
tendrl-ansible-1.6.3-6.el7rhgs.noarch
tendrl-api-1.6.3-5.el7rhgs.noarch
tendrl-api-httpd-1.6.3-5.el7rhgs.noarch
tendrl-commons-1.6.3-11.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-8.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-8.el7rhgs.noarch
tendrl-node-agent-1.6.3-9.el7rhgs.noarch
tendrl-notifier-1.6.3-4.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-9.el7rhgs.noarch

Comment 15 errata-xmlrpc 2018-09-04 07:08:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616