Bug 1595211

Summary: PATCH: fix Window title being <unknown> and non svg icon being used
Product: [Fedora] Fedora Reporter: Hans de Goede <hdegoede>
Component: audaciousAssignee: Michael Schwendt <bugs.michael>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: bugs.michael, malkodan, redhat-bugzilla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-28 21:53:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
[PATCH] Pass "audacious" to gtk_init as argv[0] so that WM_CLASS gets set correctly
none
[PATCH] Pass application basename to gtk_init().
none
[PATCH] Pass application basename to gtk_init(). none

Description Hans de Goede 2018-06-26 11:28:21 UTC
Hi,

I noticed that after upgrading to F28 audacious icon in alt-tab was blurry (non svg icon used) and the title below the icon was <unknown>.

I've written a small patch fixing this (I will also submit this upstream) here is the commit message from the patch:

[PATCH] Pass "audacious" to gtk_init as argv[0] so that WM_CLASS gets set correctly

Before this commit the WM_CLASS of gtk2 builds of audacious-3.9 would be set to "<unknown>", "<unknown>".

This commit passes "audacious" to gtk_init as argv[0], which changes WM_CLASS to "audacious", "Audacious".

This fixes the Window title (in alt-tab) being <unknown> and a non svg icon being used under GNOME 3.28.

Regards,

Hans

Comment 1 Hans de Goede 2018-06-26 11:28:55 UTC
Created attachment 1454626 [details]
[PATCH] Pass "audacious" to gtk_init as argv[0] so that WM_CLASS gets set correctly

Comment 2 Hans de Goede 2018-06-26 11:37:37 UTC
Submitted upstream:
https://github.com/audacious-media-player/audacious/pull/31

Comment 3 Hans de Goede 2018-06-27 07:36:13 UTC
Created attachment 1454962 [details]
[PATCH] Pass application basename to gtk_init().

Upstream went with a slightly different version of the patch, I'm attaching upstream's version.

Comment 4 Hans de Goede 2018-06-27 07:44:18 UTC
Created attachment 1454964 [details]
[PATCH] Pass application basename to gtk_init().

I just realized the version from upstream master will not apply to the 3.9.x versions, here is a backported version.

Comment 5 Michael Schwendt 2018-07-19 22:45:38 UTC
As I cannot reproduce the blurred icon and since the patch has been applied upstream, that is good enough in my opinion. I release new upstream versions regularly at https://copr.fedorainfracloud.org/coprs/mschwendt/audacious-next/
Such as 3.10-beta1 which is still plugin compatible with 3.9.

Comment 6 Ben Cotton 2019-05-02 21:17:09 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Ben Cotton 2019-05-28 21:53:56 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.