Bug 1595669
| Summary: | Restore -v in set deployment-hook and status commands | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Maciej Szulik <maszulik> |
| Component: | oc | Assignee: | Maciej Szulik <maszulik> |
| Status: | CLOSED ERRATA | QA Contact: | zhou ying <yinzhou> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.11.0 | CC: | aos-bugs, jokerman, mmccomas, xxia |
| Target Milestone: | --- | ||
| Target Release: | 3.11.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-10-11 07:20:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Maciej Szulik
2018-06-27 10:30:34 UTC
PR in-flight: https://github.com/openshift/origin/pull/20412 $ oc status -v -n xxia-proj Flag shorthand -v has been deprecated, Use --suggest instead. Will be dropped in a future release Flag --v has been deprecated, Use --suggest instead. Will be dropped in a future release ... $ oc set deployment-hook dc/ruby-ex --pre -v myvolume -- /bin/true Flag shorthand -v has been deprecated, Use --volumes instead. Flag --v has been deprecated, Use --volumes instead. Will be dropped in a future release ... The second line about --v "Flag --v has been deprecated ..." needs be removed. Besides, -v is still showing in `oc options`: -v, --v=0: log level for V logs This causes issue: $ oc status --v=6 Error: invalid argument "6" for "--v" flag: strconv.ParseBool: parsing "6": invalid syntax If this bug wants to restore -v in oc status and oc set deployment-hook, -v should be removed from `oc options` `oc set deployment-hook -h` has some examples of `oc set deployment-hook ... -v`, it's better to replace them with --volumes BTW. Thanks. Checked in oc v3.11.0-0.11.0, comment 3 is fixed. The comment 2 issue still exists. Seems comment 2's fix is missed in the new PR, could you PTAL? Yeah, you're right, fix is in https://github.com/openshift/origin/pull/20582. Commit pushed to master at https://github.com/openshift/origin https://github.com/openshift/origin/commit/875f246288331c9e3acc861f3c2447f72db6963b Merge pull request #20582 from soltysh/bug1595669 Bug 1608254 - update help messages Checked oc v3.11.0-0.16.0, the beginning half part of comment 2 about `oc status/set ... -v ...` showing irrelevant 'Flag --v' is fixed. But the ending half part of comment 2 still exists about: `oc options` displaying '-v, --v=0' where -v is included. `oc status --v=6` showing Error: invalid argument ... Please help check again. oc options is global, the --v is fixed and different only for set deployment-hook and status commands. It will disappear eventually and then oc options output will make sense. OK, though it is a bit imperfect. Verified Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:2652 |