Bug 159623

Summary:	local variable used before set
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	libgnome	Assignee:	Ray Strode [halfline] <rstrode>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-07-25 18:08:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-06-06 08:21:59 UTC

Description of problem:

I just tried to compile package libgnome-2.10.0-3 from Redhat
Fedora Core development tree with the most excellent Intel C compiler.

The compiler said

gnome-program.c(1936): remark #592: variable "args" is used before its value is
set

The source code is

    va_list args;

    g_return_val_if_fail (nparams >= 0, NULL);

    return gnome_program_init_common (type, app_id, app_version, module_info,
                                      argc, argv, NULL, args, nparams, params);


Clearly broken code. There is a missing call to va_start for local 
variable "args".


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Ray Strode [halfline] 2006-07-25 18:08:57 UTC

This has been fixed for a while now I think.