Bug 159624
| Summary: | startx failed to start ssh-agent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeff Garzik <jgarzik> |
| Component: | xorg-x11-xinit | Assignee: | Søren Sandmann Pedersen <sandmann> |
| Status: | CLOSED DUPLICATE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aidan, chris.ricker, kem, peterm |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | FC5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-18 02:45:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 150223 | ||
|
Description
Jeff Garzik
2005-06-06 08:23:09 UTC
It's a regression from 3. I'm seeing it with 4 as well /etc/X11/xinit/xinitrc-common used to start ssh-agent (pre-FC4)
Now (in FC4) it sets the SSH_AGENT environment variable, and other scripts
should to the right thing.
For xdm logins, /etc/X11/xdm/Xsessions does the right thing and runs $SSH_AGENT.
However /etc/X11/xinit/xinitrc needs to be updated - something like:
if [ -f $HOME/.Xclients ]; then
exec $SSH_AGENT $DBUS_LAUNCH $HOME/.Xclients || \
exec $SSH_AGENT $HOME/.Xclients
elif [ -f /etc/X11/xinit/Xclients ]; then
exec $SSH_AGENT $DBUS_LAUNCH /etc/X11/xinit/Xclients || \
exec $SSH_AGENT /etc/X11/xinit/Xclients
else
# failsafe settings. Although we should never get here
# (we provide fallbacks in Xclients as well) it can't hurt.
xclock -geometry 100x100-5+5 &
xterm -geometry 80x50-50+150 &
if [ -x /usr/X11R6/bin/twm ]; then
exec $SSH_AGENT /usr/X11R6/bin/twm
fi
fi
I'm presuming that the change was made to solve the problem which existed in
earlier versions that an ssh-agent was started by "startx" but that agent wasn't
killed when X exited - so one could end up with many ssh-agent processes running.
>I'm presuming that the change was made to solve the problem which existed
>in earlier versions that an ssh-agent was started by "startx" but that agent
>wasn't killed when X exited - so one could end up with many ssh-agent processes
>running.
I believe this is correct. If someone has an idea how to solve both
problems, and also provide both levels of functionality, feel free to
suggest ideas for review.
If this problem still exists in FC5, please reopen. Still broken in FC5 Add to FC6Destop tracker so the ssh-agent man page says: "If a commandline is given, this is executed as a subprocess of the agent. When the command dies, so does the agent." If it didn't behave that way, then the GDM case would have the same problem. We should just fix it with the proposed fix. |