Bug 1596469

Summary:	vsftpd logins fail if uid < 1000 after FC28 upgrade
Product:	[Fedora] Fedora	Reporter:	dan
Component:	vsftpd	Assignee:	Ondřej Lysoněk <olysonek>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	jaskalnik, mosvald, msehnout, nagy.martin, olysonek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-28 20:48:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description dan 2018-06-29 05:08:01 UTC

System with a working vsftpd environment upgraded to FC28 from FC27.  Login of uid 500 now fails where it used to be permitted.

Here is a journal entry of success from FC27:

Feb 16 17:51:30 lin1 audit[1446]: CRED_ACQ pid=1446 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:ftpd_t:s0-s0:c0.c1023 msg='op=PAM:setcred grantors=pam_listfile,pam_shells,pam_unix acct="someacct" exe="/usr/sbin/vsftpd" hostname=somehost addr=someaddr terminal=ftp res=success'

Now with FC28, logins fail with the following journal entries:

Jun 29 00:42:50 lin1 vsftpd[1964]: pam_succeed_if(vsftpd:auth): requirement "uid >= 1000" not met by user "someuser"
Jun 29 00:42:50 lin1 audit[1964]: USER_AUTH pid=1964 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:ftpd_t:s0-s0:c0.c1023 msg='op=PAM:authentication grantors=? acct="someuser" exe="/usr/sbin/vsftpd" hostname=localhost addr=::1 terminal=ftp res=failed'

The uid of someuser is 500 and someuser is listed in /etc/vsftpd/user_list.  The login shell of someuser is /sbin/nologin.

Comment 1 dan 2018-06-29 05:26:14 UTC

Did some further testing after renumbering uid to 1001.  Still failed.

Next I added /sbin/nologin to /etc/shells.

Now the user can login successfully via vsftpd.  Not certain that it is desirable or how things are intended.

Please review.

Comment 2 Ondřej Lysoněk 2018-06-29 07:44:28 UTC

Thanks for the report. I found that /sbin/nologin was removed from /etc/shells per this bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1378893

I'll see what we can do.

Comment 3 dan 2018-06-29 13:57:17 UTC

Was the PAM restriction against uid < 1000 also by intent?

Comment 4 dan 2018-06-29 20:45:57 UTC

It looks like the PAM restriction is in password-auth, used by vsftpd's pam definition.  I checked FC27 and this restriction was not in pam 1.3.0-6 which was used by FC27.

Comment 5 Ben Cotton 2019-05-02 19:22:58 UTC

This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Ben Cotton 2019-05-02 21:30:34 UTC

This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Ben Cotton 2019-05-28 20:48:08 UTC

Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.