Bug 1596577

Summary:	diffoscope-96-1.fc29 FTBFS with Python 3.7
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	diffoscope	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dhiru, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	diffoscope-98-1.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-04 18:03:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1565020

Description Miro Hrončok 2018-06-29 09:36:45 UTC

https://koji.fedoraproject.org/koji/taskinfo?taskID=27942590

SyntaxError: Generator expression must be parenthesized
  File "/usr/lib/python3.7/site-packages/diffoscope/comparators/json.py", line 41
SyntaxError: Generator expression must be parenthesized

Version-Release number of selected component: diffoscope-96-1.fc29


Reproducer: fedpkg build --target=f29-python

Comment 1 Miro Hrončok 2018-06-29 09:39:23 UTC

Trying with 98.

Comment 2 Miro Hrončok 2018-06-29 09:46:35 UTC

98 gets to tests, but the tests fail:

Python 3.6: 152 failed, 97 passed, 58 skipped, 65 error

Python 3.7: 152 failed, 96 passed, 59 skipped, 65 error

Comment 3 Miro Hrončok 2018-07-02 18:21:02 UTC

The side tag is no more. Once fixed, build in regular rawhide.