Bug 1597479

Summary: virt-p2v version is wrong in virt-p2v client
Product: Red Hat Enterprise Linux 7 Reporter: mxie <mxie>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED NOTABUG QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.6CC: juzhou, mxie, mzhan, ptoscano, tzheng, xiaodwan
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: P2V
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-02 14:43:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
virt-p2v-version
none
virt-p2v-version-2
none
virt-p2v-1.38.2-1 none

Description mxie@redhat.com 2018-07-03 03:22:08 UTC
Created attachment 1456089 [details]
virt-p2v-version

Description of problem:
virt-p2v version is wrong in virt-p2v client

Version-Release number of selected component (if applicable):
virt-p2v-1.38.2-2.el7.noarch
virt-v2v-1.38.2-6.el7.x86_64
libguestfs-1.38.2-6.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Boot host into virt-p2v client
2.Check virt-p2v version in "About virt-p2v..." option, found virt-p2v version is wrong,pls refer to screenshot"virt-p2v-version"
3.At inputting conversion info interface. found virt-p2v version is also wrong "virt-p2v-version-2"


Actual results:
As above description

Expected results:
virt-p2v version is correct in virt-p2v client

Additional info:

Comment 3 mxie@redhat.com 2018-07-03 03:22:35 UTC
Created attachment 1456090 [details]
virt-p2v-version-2

Comment 4 Pino Toscano 2018-07-03 06:27:55 UTC
It looks correct to me, why do you think it is wrong?

Comment 5 mxie@redhat.com 2018-07-03 06:54:01 UTC
virt-p2v actual version is 1.38.2-2, but version shows 1.38.2 rhel7,release 6, it should be 1.38.2 rhel7,release 2

Comment 6 Pino Toscano 2018-07-03 07:08:48 UTC
(In reply to mxie from comment #5)
> version shows 1.38.2 rhel7,release6

The virt-p2v application is built from the same source of libguestfs, so its version is the same as libguestfs.

> virt-p2v actual version is 1.38.2-2

This is the version of the virt-p2v ISO (i.e. the live system that runs the virt-p2v application), and the wrapper RPM that contains the ISO.

The virt-p2v ISO is usually rebuilt when either:
a) libguestfs is rebased to a new version
b) a new build of libguestfs has changes in the virt-p2v application
c) there are important changes in the base OS to include
so that is why the versions of libguestfs and the virt-p2v ISO are not always in sync. OTOH it should not be an issue, since the version of the virt-p2v application is what usually matters.

Comment 7 mxie@redhat.com 2018-07-03 07:21:13 UTC
   But virt-p2v client vrersion was always consistent with virt-p2v iso version before, such as virt-p2v-1.38.2-1.el7.iso, the p2v version shows 1.38.2 rhel7,release 1 in client, pls refer to screenshot"virt-p2v-1.38.2-1",
   And I think if virt-p2v client version is not consistent with virt-p2v iso version will confuse customer

Comment 8 mxie@redhat.com 2018-07-03 07:22:01 UTC
Created attachment 1456130 [details]
virt-p2v-1.38.2-1

Comment 9 Pino Toscano 2018-07-03 10:32:35 UTC
(In reply to mxie from comment #7)
>    But virt-p2v client vrersion was always consistent with virt-p2v iso
> version before, such as virt-p2v-1.38.2-1.el7.iso, the p2v version shows
> 1.38.2 rhel7,release 1 in client, pls refer to screenshot"virt-p2v-1.38.2-1",

So far that happened by chance, i.e. the versions of the virt-p2v application and the virt-p2v ISO were never in sync.

Comment 10 Pino Toscano 2018-08-02 14:43:04 UTC
As already mentioned, this is not a bug.