Bug 1597723

Summary:	RFE: validate nic templates during openstack overcloud upgrade prepare
Product:	Red Hat OpenStack	Reporter:	Marius Cornea <mcornea>
Component:	RFEs	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	17.0 (Wallaby)	CC:	ccamacho, hjensas, jpretori, markmc, mburns, morazi, srevivo
Target Milestone:	---	Keywords:	FutureFeature, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-07 15:29:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1896763

Description Marius Cornea 2018-07-03 14:00:32 UTC

Description of problem:

Before running overcloud ffwd-upgrade prepare the user needs to convert the nic templates to new format. In case the conversion doesn't go right(see BZ#1596824) or is missed by the operator then the nodes can potentially lose network connectivity during the FFU process.

This request asks for a validation that runs automatically during overcloud ffwd-upgrade prepare and prevents the upgrade process to start when the nic templates were erroneously converted or were not converted at all. The failure message should point the user to the root cause of the failure.

Comment 3 Yaniv Kaul 2021-07-07 13:11:26 UTC

This is probably a good idea, but was not implemented in 3 years - do we see it happening for 17, or shall we close it (move upstream, etc.) ?

Comment 4 Marius Cornea 2021-07-07 15:29:23 UTC

(In reply to Yaniv Kaul from comment #3)
> This is probably a good idea, but was not implemented in 3 years - do we see
> it happening for 17, or shall we close it (move upstream, etc.) ?

I think we can close it.

Comment 5 Harald Jensås 2021-07-07 15:56:03 UTC

For 16-17 we will have a major migration of heat template -> ansible j2 template happening.
There is a tool[1], but my guess is not even 1 person tested it yet. (Based on: no one reported issues yet ...)

I think validations for the conversion would be good, but it is also hard to implement. Since pretty much all deployments are unique, it would take a huge amount of resource to cover a the infinite permutations possible.


 For the 16 -> 17 upgrade, we need downstream CI; all DFG's; to use the tool[1] to convert their existing Heat template based NIC templates to Ansible j2 templates.
 And open bugs when it does not work so that we can make the tool as good as possible.
 It is possible bugs reported would provide valuable data to implement targeted validations for common issues.


[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/tools/convert_heat_nic_config_to_ansible_j2.py