Bug 1598311

Summary:	Error message is weird when there is no enough pci slot for hotplug interface
Product:	Red Hat Enterprise Linux 7	Reporter:	yalzhang <yalzhang>
Component:	libvirt	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	yalzhang <yalzhang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.6	CC:	berrange, dyuan, fjin, jsuchane, laine, lmen, meili, xuzhang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-4.5.0-4.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-30 09:57:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description yalzhang@redhat.com 2018-07-05 05:51:57 UTC

Description of problem:
Error message weird when there is no enough pci slot for hotplug interface

Version-Release number of selected component (if applicable):
libvirt-4.5.0-1.el7.x86_64


How reproducible:
100%

Steps to Reproduce:
1. start a guest, then hotplug interface with below command
# for i in `seq 32`;do  echo -----$i------; virsh attach-interface rhel network default; done
-----1------
Interface attached successfully
......
-----21------
error: Failed to attach interface
error: Network filter binding not found: no nwfilter binding for port dev 'vnet20'
-----22------
error: Failed to attach interface
error: Network filter binding not found: no nwfilter binding for port dev 'vnet20'


Actual results:
When there is no enough pci slots, the error messages is weird about network filter

Expected results:
the error message should be like:
error: Failed to attach interface
error: internal error: No more available PCI slots
(test on libvirt-4.4.0-2.el7.x86_64)

Additional info:

Comment 2 Laine Stump 2018-07-06 16:05:41 UTC

It sounds like the nwfilter "error" is happening during cleanup (we're attempting to removing nwfilter bindings that we hadn't yet created), so it's obscuring the original error. I don't have time to look in more detail now.

Comment 3 Katerina Koukiou 2018-07-13 15:37:30 UTC

https://www.redhat.com/archives/libvir-list/2018-July/msg00882.html

Comment 4 Katerina Koukiou 2018-07-16 08:59:48 UTC

Fixed with v4.5.0-147-gf7b55665cc:

commit f7b55665cc6b805bc4c34e1ec5908df31084ef5c
Author: Katerina Koukiou <kkoukiou>
Date:   Fri Jul 13 17:01:44 2018 +0200

    qemu: hotplug: don't overwrite error message in qemuDomainAttachNetDevice

Comment 7 yalzhang@redhat.com 2018-07-26 01:00:00 UTC

Test on libvirt-4.5.0-4.el7.x86_64 with the same steps in comment 0, the result is as expected, set this bug to be verified.

Comment 9 errata-xmlrpc 2018-10-30 09:57:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:3113